From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82B3DC77B7A for ; Thu, 18 May 2023 14:31:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231321AbjEROb6 (ORCPT ); Thu, 18 May 2023 10:31:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54524 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230049AbjEROb4 (ORCPT ); Thu, 18 May 2023 10:31:56 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C44010E5 for ; Thu, 18 May 2023 07:31:54 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A9A7B22235; Thu, 18 May 2023 14:31:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1684420313; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+vp85ppHBjvgs13g9iFXFd7MECAHieQCAHCOCBIubH4=; b=Aler/rDn6umpJuIDfCLwwHeyJY6AyvlTO+HTULdNMaMwFF5l5rdMwaWmHoF6/v4xxEksBp oI/dGbFMdVSmY8537yHsQAPF0OnZkJxSkd0QjqcU3uijG3PyoxunKOcpBJeXti0H5M3NA4 0bWcRZeZjbpuKlshfUpTMwnUaDayOS8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1684420313; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+vp85ppHBjvgs13g9iFXFd7MECAHieQCAHCOCBIubH4=; b=ddjIXrX3wYb4edgrQbfa4UjLrFeTkydda9E18wkLexWalP2LLdFa6qFj1Y8JbOYZbA3DH7 Bu9ZIyP/ev9RzCBQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 10DFE138F5; Thu, 18 May 2023 14:31:53 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id uqgOAdk2ZmQEXQAAMHmgww (envelope-from ); Thu, 18 May 2023 14:31:53 +0000 Date: Thu, 18 May 2023 16:31:46 +0200 Message-ID: <87wn15hfsd.wl-tiwai@suse.de> From: Takashi Iwai To: Oswald Buddenhagen Cc: Tom Rix , perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: emu10k1: set variables emu1010_routing_info and emu1010_pads_info storage-class-specifier to static In-Reply-To: References: <20230518123826.925752-1-trix@redhat.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 18 May 2023 15:58:51 +0200, Oswald Buddenhagen wrote: > > On Thu, May 18, 2023 at 08:38:26AM -0400, Tom Rix wrote: > > smatch reports > ^^^^^^ is this the best word to use here? Note that smatch is a name of a static analysis tool :) > > sound/pci/emu10k1/emumixer.c:519:39: warning: symbol > > 'emu1010_routing_info' was not declared. Should it be static? > > sound/pci/emu10k1/emumixer.c:859:36: warning: symbol > > 'emu1010_pads_info' was not declared. Should it be static? > > > > These variables are only used in their defining file, so it should be static > ^^ they > > > > Signed-off-by: Tom Rix > > > Reviewed-by: Oswald Buddenhagen > > (also amending one of the still pending patches. thanks!) Applied the patch now, thanks. Takashi