From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7E21C4708E for ; Wed, 4 Jan 2023 10:12:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234847AbjADKL5 (ORCPT ); Wed, 4 Jan 2023 05:11:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42640 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234672AbjADKLg (ORCPT ); Wed, 4 Jan 2023 05:11:36 -0500 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3AAF16160; Wed, 4 Jan 2023 02:11:35 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id CF59C3EC52; Wed, 4 Jan 2023 10:11:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1672827093; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2Wf8/FIMUYrQBgeOJTLbyqmuHcLemKRfaSwIgj/ziLY=; b=jIUUFUU4O3+mr00mQ7oQ+W+IN6muOpQoiGa1T4DXF48Lx9Y3A5n1l3SM5VZCFtXmV9rKtO PWozl0rpB0LiTs1pgl+y+qx9yOF2gc7x35uoNxzClAeKaIqmHP7juHQFr+amDAbnvPtsGn Awxy+tP6CsmdlT8zN3wPbrKXwlKuyvU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1672827093; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2Wf8/FIMUYrQBgeOJTLbyqmuHcLemKRfaSwIgj/ziLY=; b=D0MHobL4tuE7ZPWKE8E97wXFBOr64KvTOm6Rw/I7BhK9Q5o1j91ixSHvtER+J+tV0YG4/M fEf/9Vm6HgpdY/DA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 93007133D1; Wed, 4 Jan 2023 10:11:33 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id swQFI9VQtWPZTQAAMHmgww (envelope-from ); Wed, 04 Jan 2023 10:11:33 +0000 Date: Wed, 04 Jan 2023 11:11:33 +0100 Message-ID: <87wn62obhm.wl-tiwai@suse.de> From: Takashi Iwai To: Greg Kroah-Hartman Cc: stable@vger.kernel.org, =?ISO-8859-1?Q?P=C1LFFY_D=E1niel?= , Alsa-devel , "regressions@lists.linux.dev" , Mark Brown , LKML , Takashi Iwai , Richard Fitzgerald , Thorsten Leemhuis , Sergey , Salvatore Bonaccorso Subject: Request for cherry-picks for sound (Re: [regression, 5.10.y] Bug 216861) In-Reply-To: <87sfgrpos6.wl-tiwai@suse.de> References: <87wn65umye.wl-tiwai@suse.de> <87h6x7r7w6.wl-tiwai@suse.de> <87sfgrpos6.wl-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Greg, just in case you missed my previous post. Could you cherry-pick the following two commits to 5.10.y and 5.15.y stable trees? e8444560b4d9302a511f0996f4cfdf85b628f4ca ASoC/SoundWire: dai: expand 'stream' concept beyond SoundWire 636110411ca726f19ef8e87b0be51bb9a4cdef06 ASoC: Intel/SOF: use set_stream() instead of set_tdm_slots() for HDAudio Thanks! Takashi On Tue, 03 Jan 2023 17:26:49 +0100, Takashi Iwai wrote: > > On Tue, 03 Jan 2023 15:48:41 +0100, > Takashi Iwai wrote: > > > > On Tue, 03 Jan 2023 14:04:50 +0100, > > PÁLFFY Dániel wrote: > > > > > > And confirming, 5.10.161 with e8444560b4d9302a511f0996f4cfdf85b628f4ca > > > and 636110411ca726f19ef8e87b0be51bb9a4cdef06 cherry-picked works for > > > me. > > > > That's a good news. Then we can ask stable people to pick up those > > commits for 5.10.y and 5.15.y. > > I confirmed that the latest 5.15.y requires those fixes, too. > > Greg, could you cherry-pick the following two commits to both 5.10.y > and 5.15.y stable trees? This fixes the recent regression caused by > the backport of 39bd801d6908. > > e8444560b4d9302a511f0996f4cfdf85b628f4ca > ASoC/SoundWire: dai: expand 'stream' concept beyond SoundWire > > 636110411ca726f19ef8e87b0be51bb9a4cdef06 > ASoC: Intel/SOF: use set_stream() instead of set_tdm_slots() for HDAudio > > > Thanks! > > Takashi > > > > > > > Takashi > > > > > > > > On Tue, Jan 3, 2023 at 1:05 PM PÁLFFY Dániel wrote: > > > > > > > > Another report: https://bugs.archlinux.org/task/76795 > > > > Apparently, folks at alsa-devel traced down the dependencies of that patch, see the mail thread at https://lore.kernel.org/all/dc65501c-c2fd-5608-c3d9-7cea184c3989%40opensource.cirrus.com/ > > > > > > > > On Mon, Jan 2, 2023 at 1:42 PM Takashi Iwai wrote: > > > >> > > > >> On Mon, 02 Jan 2023 11:43:36 +0100, > > > >> Salvatore Bonaccorso wrote: > > > >> > > > > >> > Hi, > > > >> > > > > >> > [Adding as well Richard Fitzgerald and PÁLFFY Dániel to recipients] > > > >> > > > > >> > On Fri, Dec 30, 2022 at 09:08:57AM +0100, Thorsten Leemhuis wrote: > > > >> > > Hi, this is your Linux kernel regression tracker speaking. > > > >> > > > > > >> > > I noticed a regression report in bugzilla.kernel.org. As many (most?) > > > >> > > kernel developer don't keep an eye on it, I decided to forward it by > > > >> > > mail. Quoting from https://bugzilla.kernel.org/show_bug.cgi?id=216861 : > > > >> > > > > > >> > > > Sergey 2022-12-29 10:07:51 UTC > > > >> > > > > > > >> > > > Created attachment 303497 [details] > > > >> > > > pulseaudio.log > > > >> > > > > > > >> > > > Sudden sound disappearance was reported for some laptops, e.g. > > > >> > > > > > > >> > > > Acer Swift 3 SF314-59-78UR 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz > > > >> > > > > > > >> > > > # lspci > > > >> > > > 0000:00:1f.3 Multimedia audio controller: Intel Corporation Tiger Lake-LP Smart Sound Technology Audio Controller (rev 20) > > > >> > > > Subsystem: Acer Incorporated [ALI] Device 148c > > > >> > > > Flags: bus master, fast devsel, latency 32, IRQ 197, IOMMU group 12 > > > >> > > > Memory at 601f270000 (64-bit, non-prefetchable) [size=16K] > > > >> > > > Memory at 601f000000 (64-bit, non-prefetchable) [size=1M] > > > >> > > > Capabilities: [50] Power Management version 3 > > > >> > > > Capabilities: [80] Vendor Specific Information: Len=14 > > > >> > > > Capabilities: [60] MSI: Enable+ Count=1/1 Maskable- 64bit+ > > > >> > > > Kernel driver in use: sof-audio-pci > > > >> > > > > > > >> > > > I am attaching the pulseaudio and dmesg logs > > > >> > > > > > > >> > > > This bug started reproducing after updating the kernel from 5.10.156 to 5.10.157 > > > >> > > > > > > >> > > > Bisection revealed the commit being reverted: > > > >> > > > > > > >> > > > c34db0d6b88b1da95e7ab3353e674f4f574cccee is the first bad commit > > > >> > > > commit c34db0d6b88b1da95e7ab3353e674f4f574cccee > > > >> > > > Author: Richard Fitzgerald > > > >> > > > Date: Fri Nov 4 13:22:13 2022 +0000 > > > >> > > > > > > >> > > > ASoC: soc-pcm: Don't zero TDM masks in __soc_pcm_open() > > > >> > > > > > > >> > > > [ Upstream commit 39bd801d6908900e9ab0cdc2655150f95ddd4f1a ] > > > >> > > > > > > >> > > > The DAI tx_mask and rx_mask are set by snd_soc_dai_set_tdm_slot() > > > >> > > > and used by later code that depends on the TDM settings. So > > > >> > > > __soc_pcm_open() should not be obliterating those mask values. > > > >> > > > > > > >> > > > [...] > > > >> > > > Original bug report: https://bugzilla.altlinux.org/44690 > > > >> > > > > > >> > > See the ticket for more details. > > > >> > > > > > >> > > BTW, let me use this mail to also add the report to the list of tracked > > > >> > > regressions to ensure it's doesn't fall through the cracks: > > > >> > > > > > >> > > #regzbot introduced: c34db0d6b88b1d > > > >> > > https://bugzilla.kernel.org/show_bug.cgi?id=216861 > > > >> > > #regzbot title: sound: asoc: sudden sound disappearance > > > >> > > #regzbot ignore-activity > > > >> > > > > >> > FWIW, we had as well reports in Debian after having updated the kernel > > > >> > from 5.10.149 based one to 5.10.158 based one in the last point > > > >> > releases, they are at least: > > > >> > > > > >> > https://bugs.debian.org/1027483 > > > >> > https://bugs.debian.org/1027430 > > > >> > > > >> I got another report while the commit was backported to 5.14-based > > > >> openSUSE Leap kernel, and I ended up with dropping it. > > > >> > > > >> So, IMO, it's safer to drop this patch from the older stable trees. > > > >> As far as I see, 5.15.y and 5.10.y got this. > > > >> > > > >> Unless anyone gives a better fix, I'm going to submit a revert patch > > > >> for those trees. > > > >> > > > >> > > > >> thanks, > > > >> > > > >> Takashi > > > > >