From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2A3DC433F5 for ; Sun, 9 Oct 2022 00:57:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229682AbiJIA5u (ORCPT ); Sat, 8 Oct 2022 20:57:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50474 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229551AbiJIA5s (ORCPT ); Sat, 8 Oct 2022 20:57:48 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 04EAEAE64 for ; Sat, 8 Oct 2022 17:57:46 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A4007B80C2E for ; Sun, 9 Oct 2022 00:57:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 415DCC433D6; Sun, 9 Oct 2022 00:57:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1665277064; bh=kMOKD59f4KaUW+9KnwqjenV3cMWROfUTbCFt6uFlQvA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=MGpIPMwFJuSFht5MaTwrAuYeN3xVv1eL1pQclczyKBL27moceZ0qx9mD+B9PiadD2 TZan66BlBY4i3Pg9OaIXjAJmJsBXgV8bb1ztMQTlXPJNALmgbC431te0tJQ1mqL82M QMobhH9hWXz6hkjxoHamHviOLaXCwgcC2JbMmZIz5W6uk5hHFcY+927DhNX2CWXtxh 2LMFiqptS8F9D7ts7FLLZsMufK32bXItk+CyYQcoR3DXwkekVbZLvB0TdAcZ+mt7rE 4We1hI0Z57OqYWocSoSbncH6YT8rPMUZhOGL0XEzGKusttQpAQFp/WWgve8zVDzleb yXlsKvJaJnNiQ== Received: from [156.39.10.100] (helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1ohKdR-00FKj4-LB; Sun, 09 Oct 2022 01:57:42 +0100 Date: Sun, 09 Oct 2022 01:56:43 +0100 Message-ID: <87wn99hl10.wl-maz@kernel.org> From: Marc Zyngier To: Konrad Dybcio Cc: ~postmarketos/upstreaming@lists.sr.ht, asahi@lists.linux.dev, Hector Martin , Sven Peter , Alyssa Rosenzweig , martin.botka@somainline.org, angelogioacchino.delregno@somainline.org, marijn.suijten@somainline.org, jamipkettunen@somainline.org, Thomas Gleixner , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 2/2] irqchip/apple-aic: Add support for A7-A11 SoCs In-Reply-To: <06a1b6fa-d179-97c7-995e-91d93123a5de@somainline.org> References: <20221007200022.22844-1-konrad.dybcio@somainline.org> <20221007200022.22844-3-konrad.dybcio@somainline.org> <37c075fc9aa9624d65b8fdda3cb5ae96@kernel.org> <06a1b6fa-d179-97c7-995e-91d93123a5de@somainline.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 156.39.10.100 X-SA-Exim-Rcpt-To: konrad.dybcio@somainline.org, ~postmarketos/upstreaming@lists.sr.ht, asahi@lists.linux.dev, marcan@marcan.st, sven@svenpeter.dev, alyssa@rosenzweig.io, martin.botka@somainline.org, angelogioacchino.delregno@somainline.org, marijn.suijten@somainline.org, jamipkettunen@somainline.org, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 08 Oct 2022 08:03:23 +0100, Konrad Dybcio wrote: >=20 >=20 >=20 > On 8.10.2022 01:17, Marc Zyngier wrote: > > On 2022-10-07 21:00, Konrad Dybcio wrote: > >> Add support for A7-A11 SoCs by if-ing out some features only present > >> on A11 & newer (implementation-defined IPI & UNCORE registers). > >> > >> Also, annotate IPI regs support in the aic struct so that the driver > >> can tell whether the SoC supports these, as they are written to, > >> even if fast IPI is disabled. This in turn causes a crash on older > >> platforms, as the implemention-defined registers either do > >> something else or are not supposed to be touched - definitely not a > >> NOP though. > >> > >> Signed-off-by: Konrad Dybcio > >> --- > >> Changes since v3: > >> - Replace use_fast_ipi with has_uncore_ipi_regs in aic_init_cpu > >> (logic error, this was written to regardless of FIPI usage before, > >> but touching Sn_... regs on SoCs that don't explicitly use them for > >> IPIs makes them sepuku..) > >> - Drop A11 compatible > >> > >> =C2=A0drivers/irqchip/irq-apple-aic.c | 47 ++++++++++++++++++++++-----= ------ > >> =C2=A01 file changed, 32 insertions(+), 15 deletions(-) > >=20 > > Since you cannot be bothered to read the review comments on > > the previous versions of this series, I'll do the same with > > these patches. Feel free to stop Cc-ing me. > >=20 > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 M. > I'm sorry, I'm working on a lot of stuff right now and I was almost sure > your email only concerned adding a cover letter And yet you ignored it again. > and affirming the discussion on the fallback compatible, I couldn't care less about that, but I admire your ability to guess what an email may or may not contain! > so I did not go through it again - but that was > obviously incorrect. If you don't mind, I can respin another version of t= his > patchset, addressing your comments. That's pretty pointless at the moment, as I'm not queuing anything other than fixes (and one week between versions is a sensible pace). Come back after -rc1 with a cover letter and the various comments addressed. M. --=20 Without deviation from the norm, progress is not possible.