Re: [PATCH v2 1/7] KVM: nVMX: Introduce nested_evmcs_is_used()

Vitaly Kuznetsov
2021-05-24T14:38:18Z

Paolo Bonzini <pbonzini@redhat.com> writes:

> On 24/05/21 16:09, Vitaly Kuznetsov wrote:
>> You mean we'll be using:
>>
>> "hv_evmcs_ptr == 0" meaning "no evmcs" (like now)
>> "hv_evmcs_ptr == -1" meaing "evmcs not yet mapped" (and
>> nested_evmcs_is_used() will check for both '0' and '-1')
>> "hv_evmcs_ptr == anything else" - eVMCS mapped.
>
> I was thinking of:
>
> hv_evmcs_ptr == -1 meaning no evmcs
>
> hv_evmcs == NULL meaning "evmcs not yet mapped" (I think)
>
> hv_evmcs != NULL meaning "evmcs mapped".
>
> As usual with my suggestions, I'm not sure if this makes sense :) but if
> it does, the code should be nicer.

Ok, let me try this!

--
Vitaly