From: Valentin Schneider <valentin.schneider@arm.com>
To: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Cc: "Peter Zijlstra \(Intel\)" <peterz@infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"linux-ia64\@vger.kernel.org" <linux-ia64@vger.kernel.org>,
Sergei Trofimovich <slyfox@gentoo.org>,
debian-ia64 <debian-ia64@lists.debian.org>
Subject: Re: [PATCH 0/1] sched/topology: NUMA distance deduplication
Date: Wed, 17 Mar 2021 20:56:12 +0000 [thread overview]
Message-ID: <87wnu5pkib.mognet@arm.com> (raw)
In-Reply-To: <87zgz1pmx4.mognet@arm.com>
On 17/03/21 20:04, Valentin Schneider wrote:
> Technically it *is* coping with it, it's just dumping the entire NUMA
> distance matrix in the process... Let me see if I can't figure out why your
> system doesn't end up with nr_node_ids=1.
>
Does the below
a) compile
b) do anything?
From what I could gather, nothing actually tickles the possible map for
ia64. The standard pattern seems to be
node_possible_map = numa_nodes_parsed;
but here at a quick glance it seems it's online or nothing, so that's what
I went for.
HTH.
---
diff --git a/arch/ia64/kernel/acpi.c b/arch/ia64/kernel/acpi.c
index a5636524af76..e2af6b172200 100644
--- a/arch/ia64/kernel/acpi.c
+++ b/arch/ia64/kernel/acpi.c
@@ -446,7 +446,8 @@ void __init acpi_numa_fixup(void)
if (srat_num_cpus == 0) {
node_set_online(0);
node_cpuid[0].phys_id = hard_smp_processor_id();
- return;
+ slit_distance(0, 0) = LOCAL_DISTANCE;
+ goto out;
}
/*
@@ -489,7 +490,7 @@ void __init acpi_numa_fixup(void)
for (j = 0; j < MAX_NUMNODES; j++)
slit_distance(i, j) = i == j ?
LOCAL_DISTANCE : REMOTE_DISTANCE;
- return;
+ goto out;
}
memset(numa_slit, -1, sizeof(numa_slit));
@@ -514,6 +515,8 @@ void __init acpi_numa_fixup(void)
printk("\n");
}
#endif
+out:
+ node_possible_map = node_online_map;
}
#endif /* CONFIG_ACPI_NUMA */
next prev parent reply other threads:[~2021-03-17 20:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 19:04 [PATCH 0/1] sched/topology: NUMA distance deduplication John Paul Adrian Glaubitz
2021-03-17 19:36 ` Valentin Schneider
2021-03-17 19:47 ` John Paul Adrian Glaubitz
2021-03-17 20:04 ` Valentin Schneider
2021-03-17 20:56 ` Valentin Schneider [this message]
2021-03-17 23:26 ` John Paul Adrian Glaubitz
2021-03-18 10:28 ` John Paul Adrian Glaubitz
2021-03-18 10:48 ` Valentin Schneider
2021-03-17 21:14 ` Sergei Trofimovich
2021-03-17 21:58 ` Anatoly Pugachev
2021-03-17 23:29 ` John Paul Adrian Glaubitz
-- strict thread matches above, loose matches on Subject: below --
2021-01-22 12:39 Valentin Schneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wnu5pkib.mognet@arm.com \
--to=valentin.schneider@arm.com \
--cc=debian-ia64@lists.debian.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=slyfox@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox