From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,TVD_SUBJ_WIPE_DEBT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2ED1CC433DF for ; Thu, 21 May 2020 07:38:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0A33F20829 for ; Thu, 21 May 2020 07:38:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ellerman.id.au header.i=@ellerman.id.au header.b="J1Z4F9XG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728447AbgEUHi6 (ORCPT ); Thu, 21 May 2020 03:38:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47460 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728300AbgEUHi6 (ORCPT ); Thu, 21 May 2020 03:38:58 -0400 Received: from ozlabs.org (bilbo.ozlabs.org [IPv6:2401:3900:2:1::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D27F6C061A0E; Thu, 21 May 2020 00:38:57 -0700 (PDT) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 49SM1p0SX0z9sRK; Thu, 21 May 2020 17:38:54 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ellerman.id.au; s=201909; t=1590046736; bh=KRzHDOmfMwlaMt726UpqEu3b+oSfQAbmI4Tg50xYIik=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=J1Z4F9XG13Cdg81A5YXPatjOCGOJGjrbCIl7emvLoWP8hT7DNDtKVvXOT+CHC/N3A AXVqHxKsBXPwydnwBJp37FU9sc2zHkZULjUVmqFv1I7ojLL661ZPnr70PLZHd2130Z e8a8vn4ZYyJgD2x49ssPHCJepew46JI6a4fY6LnG/yRGNIe/ZXGU9nxBT7sj9Blhfp V/ropzRK4CQxJtoGKKPgZa/Ws+fswwWoTOtK76R4sGayCKBGWz057AHKo4RxAyMqLr 7kOhBvAFPTb4UiiAnnojRx3Wb7YQCm3frLi/yHa7PgwjWvw7badmwtXv85jF82QtR+ HqJOBSC2Syl5g== From: Michael Ellerman To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, Nathan Chancellor , Benjamin Herrenschmidt , Paul Mackerras , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, kbuild test robot Subject: Re: [PATCH] input: i8042: Remove special PowerPC handling In-Reply-To: <20200520171618.GT89269@dtor-ws> References: <87a7254bxd.fsf@mpe.ellerman.id.au> <20200518181043.3363953-1-natechancellor@gmail.com> <87ftbv87i3.fsf@mpe.ellerman.id.au> <20200520171618.GT89269@dtor-ws> Date: Thu, 21 May 2020 17:39:13 +1000 Message-ID: <87wo557n4u.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dmitry Torokhov writes: > Hi Michael, > > On Wed, May 20, 2020 at 04:07:00PM +1000, Michael Ellerman wrote: >> [ + Dmitry & linux-input ] >> >> Nathan Chancellor writes: >> > This causes a build error with CONFIG_WALNUT because kb_cs and kb_data >> > were removed in commit 917f0af9e5a9 ("powerpc: Remove arch/ppc and >> > include/asm-ppc"). >> > >> > ld.lld: error: undefined symbol: kb_cs >> >> referenced by i8042-ppcio.h:28 (drivers/input/serio/i8042-ppcio.h:28) >> >> input/serio/i8042.o:(__i8042_command) in archive drivers/built-in.a >> >> referenced by i8042-ppcio.h:28 (drivers/input/serio/i8042-ppcio.h:28) >> >> input/serio/i8042.o:(__i8042_command) in archive drivers/built-in.a >> >> referenced by i8042-ppcio.h:28 (drivers/input/serio/i8042-ppcio.h:28) >> >> input/serio/i8042.o:(__i8042_command) in archive drivers/built-in.a >> > >> > ld.lld: error: undefined symbol: kb_data >> >> referenced by i8042.c:309 (drivers/input/serio/i8042.c:309) >> >> input/serio/i8042.o:(__i8042_command) in archive drivers/built-in.a >> >> referenced by i8042-ppcio.h:33 (drivers/input/serio/i8042-ppcio.h:33) >> >> input/serio/i8042.o:(__i8042_command) in archive drivers/built-in.a >> >> referenced by i8042.c:319 (drivers/input/serio/i8042.c:319) >> >> input/serio/i8042.o:(__i8042_command) in archive drivers/built-in.a >> >> referenced 15 more times >> > >> > Presumably since nobody has noticed this for the last 12 years, there is >> > not anyone actually trying to use this driver so we can just remove this >> > special walnut code and use the generic header so it builds for all >> > configurations. >> > >> > Fixes: 917f0af9e5a9 ("powerpc: Remove arch/ppc and include/asm-ppc") >> > Reported-by: kbuild test robot >> > Signed-off-by: Nathan Chancellor >> > --- >> > drivers/input/serio/i8042-ppcio.h | 57 ------------------------------- >> > drivers/input/serio/i8042.h | 2 -- >> > 2 files changed, 59 deletions(-) >> > delete mode 100644 drivers/input/serio/i8042-ppcio.h >> >> This LGTM. >> >> Acked-by: Michael Ellerman (powerpc) >> >> I assumed drivers/input/serio would be pretty quiet, but there's >> actually some commits to it in linux-next. So perhaps this should go via >> the input tree. >> >> Dmitry do you want to take this, or should I take it via powerpc? >> >> Original patch is here: >> https://lore.kernel.org/lkml/20200518181043.3363953-1-natechancellor@gmail.com > > I'm fine with you taking it through powerpc. > > Acked-by: Dmitry Torokhov Thanks. > Also, while I have your attention ;), could you please ack or take > https://lore.kernel.org/lkml/20191002214854.GA114387@dtor-ws/ as I > believe this is the last user or input_polled_dev API and I would like > to drop it from the tree. Ooof. Sorry, you are very patient :) I have put it in my next-test. In future feel free to send me mail off-list, or ping me on irc, if I haven't picked something up after several months! cheers