From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, kvm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, "Radim Krčmář" <rkrcmar@redhat.com>,
"Joerg Roedel" <joro@8bytes.org>,
"Jim Mattson" <jmattson@google.com>
Subject: Re: [PATCH RFC 0/5] x86/KVM/svm: get rid of hardcoded instructions lengths
Date: Thu, 20 Jun 2019 14:26:25 +0200 [thread overview]
Message-ID: <87wohgfnny.fsf@vitty.brq.redhat.com> (raw)
In-Reply-To: <3515d812-e5dd-4436-b73f-1d64bc93b079@redhat.com>
Paolo Bonzini <pbonzini@redhat.com> writes:
> On 20/06/19 13:02, Vitaly Kuznetsov wrote:
>>
>> P.S. If you'd like to test the series you'll have to have a CPU without
>> NRIP_SAVE feature or forcefully disable it, something like:
>>
>> index 8d4e50428b68..93c7eaad7915 100644
>> --- a/arch/x86/kernel/cpu/amd.c
>> +++ b/arch/x86/kernel/cpu/amd.c
>> @@ -922,6 +922,9 @@ static void init_amd(struct cpuinfo_x86 *c)
>> /* AMD CPUs don't reset SS attributes on SYSRET, Xen does. */
>> if (!cpu_has(c, X86_FEATURE_XENPV))
>> set_cpu_bug(c, X86_BUG_SYSRET_SS_ATTRS);
>> +
>> + /* No nrips */
>> + clear_cpu_cap(c, X86_FEATURE_NRIPS);
>> }
>>
>> #ifdef CONFIG_X86_32
>
> Let's add a module parameter instead. Patch sent (forgot to Cc you).
>
Sure, I thought I'm the only interested person around but if there's
hope for more this definitely sounds like a good idea)
--
Vitaly
prev parent reply other threads:[~2019-06-20 12:26 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-20 11:02 [PATCH RFC 0/5] x86/KVM/svm: get rid of hardcoded instructions lengths Vitaly Kuznetsov
2019-06-20 11:02 ` [PATCH RFC 1/5] x86: KVM: svm: don't pretend to advance RIP in case wrmsr_interception() results in #GP Vitaly Kuznetsov
2019-06-20 18:49 ` Jim Mattson
2019-06-21 8:42 ` Vitaly Kuznetsov
2019-06-20 11:02 ` [PATCH RFC 2/5] x86: KVM: svm: avoid flooding logs when skip_emulated_instruction() fails Vitaly Kuznetsov
2019-06-20 18:45 ` Jim Mattson
2019-06-20 11:02 ` [PATCH RFC 3/5] x86: KVM: svm: clear interrupt shadow on all paths in skip_emulated_instruction() Vitaly Kuznetsov
2019-06-20 18:44 ` Jim Mattson
2019-06-21 8:43 ` Vitaly Kuznetsov
2019-07-31 13:50 ` Vitaly Kuznetsov
2019-07-31 16:37 ` Paolo Bonzini
2019-07-31 20:27 ` Jim Mattson
2019-07-31 23:37 ` Sean Christopherson
2019-07-31 23:45 ` Jim Mattson
2019-07-31 23:56 ` Sean Christopherson
2019-08-01 0:13 ` Paolo Bonzini
2019-08-01 0:17 ` Jim Mattson
2019-06-20 11:02 ` [PATCH RFC 4/5] x86: KVM: add xsetbv to the emulator Vitaly Kuznetsov
2019-06-20 12:18 ` Paolo Bonzini
2019-07-31 13:07 ` Vitaly Kuznetsov
2019-07-31 13:14 ` Paolo Bonzini
2019-06-20 11:02 ` [PATCH RFC 5/5] x86: KVM: svm: remove hardcoded instruction length from intercepts Vitaly Kuznetsov
2019-06-20 18:41 ` Jim Mattson
2019-06-20 12:14 ` [PATCH RFC 0/5] x86/KVM/svm: get rid of hardcoded instructions lengths Paolo Bonzini
2019-06-20 12:26 ` Vitaly Kuznetsov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wohgfnny.fsf@vitty.brq.redhat.com \
--to=vkuznets@redhat.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox