From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABAC1C5CFC1 for ; Tue, 19 Jun 2018 12:57:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6CAC920874 for ; Tue, 19 Jun 2018 12:57:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6CAC920874 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757211AbeFSM52 convert rfc822-to-8bit (ORCPT ); Tue, 19 Jun 2018 08:57:28 -0400 Received: from ozlabs.org ([203.11.71.1]:59287 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756580AbeFSM51 (ORCPT ); Tue, 19 Jun 2018 08:57:27 -0400 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPSA id 4197KK18XDz9s1B; Tue, 19 Jun 2018 22:57:25 +1000 (AEST) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au From: Michael Ellerman To: Souptick Joarder , Frederic Barrat Cc: Arnd Bergmann , Sabyasachi Gupta , Greg KH , linux-kernel@vger.kernel.org, fbarrat@linux.vnet.ibm.com, Matthew Wilcox , Andrew Donnellan , brajeswar.linux@gmail.com, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH] misc: ocxl: Change return type for fault handler In-Reply-To: References: <20180611202904.GA25538@jordon-HP-15-Notebook-PC> <5c6942da-c847-c53a-a571-4ec96f2a993d@linux.ibm.com> Date: Tue, 19 Jun 2018 22:57:24 +1000 Message-ID: <87wouvvsqz.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Souptick Joarder writes: > On Thu, Jun 14, 2018 at 9:36 PM, Frederic Barrat wrote: >> Le 11/06/2018 à 22:29, Souptick Joarder a écrit : >>> >>> Use new return type vm_fault_t for fault handler. For >>> now, this is just documenting that the function returns >>> a VM_FAULT value rather than an errno. Once all instances >>> are converted, vm_fault_t will become a distinct type. >>> >>> Ref-> commit 1c8f422059ae ("mm: change return type to vm_fault_t") >>> >>> There is an existing bug when vm_insert_pfn() can return >>> ENOMEM which was ignored and VM_FAULT_NOPAGE returned as >>> default. The new inline vmf_insert_pfn() has removed >>> this inefficiency by returning correct vm_fault_ type. >>> >>> Signed-off-by: Souptick Joarder >>> --- >> >> >> Thanks! >> >> Tested and >> Acked-by: Frederic Barrat > > Frederic, is this patch queued for 4.19 ? Not yet, you're a bit early. 4.18-rc1 only came out the other day :) Your patches are tracked here: http://patchwork.ozlabs.org/project/linuxppc-dev/list/?submitter=67924 They should appear in 4.19 unless something conflicts with them. cheers