From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753405AbdKIIUC (ORCPT ); Thu, 9 Nov 2017 03:20:02 -0500 Received: from mga14.intel.com ([192.55.52.115]:53154 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753274AbdKIITc (ORCPT ); Thu, 9 Nov 2017 03:19:32 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,368,1505804400"; d="scan'208";a="588175" From: Jani Nikula To: "Gustavo A. R. Silva" , Joonas Lahtinen , Rodrigo Vivi , David Airlie Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: Re: [PATCH] drm/i915/intel_sdvo: mark expected switch fall-throughs In-Reply-To: <20171108202725.GA7246@embeddedor.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20171108202725.GA7246@embeddedor.com> Date: Thu, 09 Nov 2017 10:20:53 +0200 Message-ID: <87wp2zammy.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 08 Nov 2017, "Gustavo A. R. Silva" wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Addresses-Coverity-ID: 141432 > Addresses-Coverity-ID: 141433 > Addresses-Coverity-ID: 141434 > Addresses-Coverity-ID: 141435 > Addresses-Coverity-ID: 141436 > Signed-off-by: Gustavo A. R. Silva Acked-by: Jani Nikula > --- > drivers/gpu/drm/i915/intel_sdvo.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_sdvo.c b/drivers/gpu/drm/i915/intel_sdvo.c > index 7437944..921e372 100644 > --- a/drivers/gpu/drm/i915/intel_sdvo.c > +++ b/drivers/gpu/drm/i915/intel_sdvo.c > @@ -1327,6 +1327,7 @@ static void intel_sdvo_pre_enable(struct intel_encoder *intel_encoder, > switch (crtc_state->pixel_multiplier) { > default: > WARN(1, "unknown pixel multiplier specified\n"); > + /* fall through */ > case 1: rate = SDVO_CLOCK_RATE_MULT_1X; break; > case 2: rate = SDVO_CLOCK_RATE_MULT_2X; break; > case 4: rate = SDVO_CLOCK_RATE_MULT_4X; break; > @@ -2274,15 +2275,15 @@ intel_sdvo_guess_ddc_bus(struct intel_sdvo *sdvo) > */ > switch (sdvo->controlled_output) { > case SDVO_OUTPUT_LVDS1: > - mask |= SDVO_OUTPUT_LVDS1; > + mask |= SDVO_OUTPUT_LVDS1; /* fall through */ > case SDVO_OUTPUT_LVDS0: > - mask |= SDVO_OUTPUT_LVDS0; > + mask |= SDVO_OUTPUT_LVDS0; /* fall through */ > case SDVO_OUTPUT_TMDS1: > - mask |= SDVO_OUTPUT_TMDS1; > + mask |= SDVO_OUTPUT_TMDS1; /* fall through */ > case SDVO_OUTPUT_TMDS0: > - mask |= SDVO_OUTPUT_TMDS0; > + mask |= SDVO_OUTPUT_TMDS0; /* fall through */ > case SDVO_OUTPUT_RGB1: > - mask |= SDVO_OUTPUT_RGB1; > + mask |= SDVO_OUTPUT_RGB1; /* fall through */ > case SDVO_OUTPUT_RGB0: > mask |= SDVO_OUTPUT_RGB0; > break; -- Jani Nikula, Intel Open Source Technology Center