From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751422AbdJRWn3 (ORCPT ); Wed, 18 Oct 2017 18:43:29 -0400 Received: from mga05.intel.com ([192.55.52.43]:63098 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750932AbdJRWn2 (ORCPT ); Wed, 18 Oct 2017 18:43:28 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,398,1503385200"; d="scan'208";a="162108928" From: Andi Kleen To: Milian Wolff Cc: acme@kernel.org, jolsa@kernel.org, namhyung@kernel.org, Linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Subject: Re: [PATCH v6 0/6] generate full callchain cursor entries for inlined frames References: <20171018185350.14893-1-milian.wolff@kdab.com> Date: Wed, 18 Oct 2017 15:43:27 -0700 In-Reply-To: <20171018185350.14893-1-milian.wolff@kdab.com> (Milian Wolff's message of "Wed, 18 Oct 2017 20:53:44 +0200") Message-ID: <87wp3sgjqo.fsf@linux.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Milian Wolff writes: > This series of patches completely reworks the way inline frames are handled. > Instead of querying for the inline nodes on-demand in the individual tools, > we now create proper callchain nodes for inlined frames. The advantages this > approach brings are numerous: Except for the comments on the one patch the other patches all look good to me. Reviewed-by: Andi Kleen -Andi