From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753297AbdJLGkH (ORCPT <rfc822;w@1wt.eu>);
        Thu, 12 Oct 2017 02:40:07 -0400
Received: from bhuna.collabora.co.uk ([46.235.227.227]:38110 "EHLO
        bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751682AbdJLGkG (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 12 Oct 2017 02:40:06 -0400
From: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
To: Wei Yongjun <weiyongjun1@huawei.com>
Cc: Xinliang Liu <z.liuxinliang@hisilicon.com>, <zourongrong@gmail.com>,
        <kong.kongxinwei@hisilicon.com>, <puck.chen@hisilicon.com>,
        <airlied@linux.ie>, <robh@kernel.org>, <rmk+kernel@armlinux.org.uk>,
        <treding@nvidia.com>, <arnd@arndb.de>, <daniel.vetter@ffwll.ch>,
        <seanpaul@chromium.org>, <jsarha@ti.com>, <noralf@tronnes.org>,
        <dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm: Fix return value check in kirin_drm_platform_probe()
Organization: Collabora
References: <1507720636-129038-1-git-send-email-weiyongjun1@huawei.com>
Date: Thu, 12 Oct 2017 03:39:59 -0300
In-Reply-To: <1507720636-129038-1-git-send-email-weiyongjun1@huawei.com> (Wei
        Yongjun's message of "Wed, 11 Oct 2017 11:17:16 +0000")
Message-ID: <87wp40oon4.fsf@dilma.collabora.co.uk>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Wei Yongjun <weiyongjun1@huawei.com> writes:

> In case of error, the function of_graph_get_remote_node() returns NULL
> pointer not ERR_PTR(). The IS_ERR() test in the return value check
> should be replaced with NULL test..

Looks good.

Reviewed-by: Gabriel Krisman Bertazi <krisman@collabora.co.uk>

-- 
Gabriel Krisman Bertazi