From: ebiederm@xmission.com (Eric W. Biederman)
To: Ian Kent <raven@themaw.net>
Cc: Andrei Vagin <avagin@openvz.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Linux Containers <containers@lists.linux-foundation.org>
Subject: Re: [PATCH RFC] mnt: umount mounts one by one in umount_tree()
Date: Wed, 14 Jun 2017 04:37:19 -0500 [thread overview]
Message-ID: <87wp8ec3lc.fsf@xmission.com> (raw)
In-Reply-To: <1497405190.2595.3.camel@themaw.net> (Ian Kent's message of "Wed, 14 Jun 2017 09:53:10 +0800")
Ian Kent <raven@themaw.net> writes:
> On Fri, 2017-05-12 at 00:08 -0700, Andrei Vagin wrote:
>> With this patch, we don't try to umount all mounts of a tree together.
>> Instead of this we umount them one by one. In this case, we see a significant
>> improvement in performance for the worsе case.
>
> Indeed, umount has been very slow for a while now.
> Even a moderately large number of mounts (~10000) become painfully slow.
>
> Re you still perusing this?
> Anything I can do to help?
>
> Eric, what are your thoughts on this latest attempt?
I have something slightly more recent. Please checkout my for-next
branch of my userns tree:
git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace.git for-next
There is one open area of semantics that I looking at with Ram Pai in
the hopes we can drive consensus before we take any patches for
better checkpoint-restart support.
Eric
prev parent reply other threads:[~2017-06-14 9:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-12 7:08 [PATCH RFC] mnt: umount mounts one by one in umount_tree() Andrei Vagin
2017-05-12 18:56 ` [PATCH v2 " Andrei Vagin
2017-06-14 1:53 ` [PATCH " Ian Kent
2017-06-14 9:37 ` Eric W. Biederman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wp8ec3lc.fsf@xmission.com \
--to=ebiederm@xmission.com \
--cc=avagin@openvz.org \
--cc=containers@lists.linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=raven@themaw.net \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).