From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754030AbdC1NwH (ORCPT ); Tue, 28 Mar 2017 09:52:07 -0400 Received: from mga03.intel.com ([134.134.136.65]:47339 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753174AbdC1NwF (ORCPT ); Tue, 28 Mar 2017 09:52:05 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,236,1486454400"; d="scan'208";a="1112941146" From: Felipe Balbi To: Javier Martinez Canillas , linux-kernel@vger.kernel.org Cc: Javier Martinez Canillas , Greg Kroah-Hartman , linux-usb@vger.kernel.org Subject: Re: [PATCH v2] usb: phy: isp1301: Add OF device ID table In-Reply-To: <20170315034646.10360-1-javier@osg.samsung.com> References: <20170315034646.10360-1-javier@osg.samsung.com> Date: Tue, 28 Mar 2017 16:45:26 +0300 Message-ID: <87wpb9frbd.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Javier Martinez Canillas writes: > The driver doesn't have a struct of_device_id table but supported devices > are registered via Device Trees. This is working on the assumption that a > I2C device registered via OF will always match a legacy I2C device ID and > that the MODALIAS reported will always be of the form i2c:. > > But this could change in the future so the correct approach is to have an > OF device ID table if the devices are registered via OF. > > Signed-off-by: Javier Martinez Canillas this is already upstream. Care to send an incremental diff in case we need this fixed further? -- balbi