From: Michael Ellerman <mpe@ellerman.id.au>
To: linux-pcmcia@lists.infradead.org
Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org, arnd@arndb.de
Subject: Re: [PATCH] drivers/pcmcia: NO_IRQ removal for electra_cf.c
Date: Tue, 14 Mar 2017 21:51:58 +1100 [thread overview]
Message-ID: <87wpbsuo4x.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <1473501690-11987-1-git-send-email-mpe@ellerman.id.au>
Michael Ellerman <mpe@ellerman.id.au> writes:
> We'd like to eventually remove NO_IRQ on powerpc, so remove usages of it
> from electra_cf.c which is a powerpc-only driver.
>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> ---
> drivers/pcmcia/electra_cf.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Ping anyone?
Or should I merge this via the powerpc tree?
cheers
> diff --git a/drivers/pcmcia/electra_cf.c b/drivers/pcmcia/electra_cf.c
> index 4d7bc3f4124a..c6fe2a4a7a6a 100644
> --- a/drivers/pcmcia/electra_cf.c
> +++ b/drivers/pcmcia/electra_cf.c
> @@ -207,7 +207,7 @@ static int electra_cf_probe(struct platform_device *ofdev)
> return -ENOMEM;
>
> setup_timer(&cf->timer, electra_cf_timer, (unsigned long)cf);
> - cf->irq = NO_IRQ;
> + cf->irq = 0;
>
> cf->ofdev = ofdev;
> cf->mem_phys = mem.start;
> @@ -313,7 +313,7 @@ fail3:
> fail2:
> release_mem_region(cf->mem_phys, cf->mem_size);
> fail1:
> - if (cf->irq != NO_IRQ)
> + if (cf->irq)
> free_irq(cf->irq, cf);
>
> if (cf->io_virt)
> --
> 2.7.4
next prev parent reply other threads:[~2017-03-14 10:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-10 10:01 [PATCH] drivers/pcmcia: NO_IRQ removal for electra_cf.c Michael Ellerman
2017-03-14 10:51 ` Michael Ellerman [this message]
2017-03-14 12:47 ` Arnd Bergmann
2017-03-15 5:35 ` Michael Ellerman
2017-03-15 12:07 ` Arnd Bergmann
2017-03-16 9:55 ` Michael Ellerman
2017-03-16 10:05 ` Arnd Bergmann
2017-03-15 17:50 ` Scott Wood
2017-03-16 9:53 ` Michael Ellerman
2017-03-21 11:36 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wpbsuo4x.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pcmcia@lists.infradead.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox