From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752375AbdAMPiR (ORCPT <rfc822;w@1wt.eu>);
        Fri, 13 Jan 2017 10:38:17 -0500
Received: from mx1.redhat.com ([209.132.183.28]:38036 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752101AbdAMPiQ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 13 Jan 2017 10:38:16 -0500
From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: Richard Cochran <richardcochran@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, devel@linuxdriverproject.org,
        linux-kernel@vger.kernel.org, Haiyang Zhang <haiyangz@microsoft.com>,
        "K. Y. Srinivasan" <kys@microsoft.com>,
        John Stultz <john.stultz@linaro.org>, Alex Ng <alexng@microsoft.com>,
        Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH RFC] hv_utils: implement Hyper-V PTP source
References: <alpine.DEB.2.20.1701101533260.3401@nanos>
        <20170113130543.7212-1-vkuznets@redhat.com>
        <20170113145048.GA29706@localhost.localdomain>
Date: Fri, 13 Jan 2017 16:38:14 +0100
In-Reply-To: <20170113145048.GA29706@localhost.localdomain> (Richard Cochran's
        message of "Fri, 13 Jan 2017 15:50:48 +0100")
Message-ID: <87wpdz0y3d.fsf@vitty.brq.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Fri, 13 Jan 2017 15:38:17 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Richard Cochran <richardcochran@gmail.com> writes:

>> +struct ptp_clock_info ptp_hyperv_info = {
>> +	.name		= "hyperv",
>> +	.enable         = hv_ptp_enable,
>> +	.gettime64      = hv_ptp_gettime,
>
> The code in drivers/ptp/ptp_clock.c calls
>
> 	.adjfreq (or adjfine)
> 	.adjtime
> 	.settime64
>
> unconditionally, so you need to implement these returning EOPNOTSUPP.
> (See also Documentation/ptp/ptp.txt)
>

Sure, thanks, will do in non-RFC version.

-- 
  Vitaly