From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754252AbcKUL4z (ORCPT ); Mon, 21 Nov 2016 06:56:55 -0500 Received: from mga02.intel.com ([134.134.136.20]:42351 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753657AbcKUL4x (ORCPT ); Mon, 21 Nov 2016 06:56:53 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,675,1473145200"; d="asc'?scan'208";a="789037236" From: Felipe Balbi To: Roger Quadros , mathias.nyman@intel.com Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Sergei Shtylyov , rogerq@ti.com Subject: Re: [PATCH v2 1/3] usb: xhci: add quirk flag for broken PED bits In-Reply-To: References: <1479394881-13863-1-git-send-email-rogerq@ti.com> <1479394881-13863-2-git-send-email-rogerq@ti.com> Date: Mon, 21 Nov 2016 13:56:00 +0200 Message-ID: <87wpfxqc6n.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Roger Quadros writes: > diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h > index f945380..6553903 100644 > --- a/drivers/usb/host/xhci.h > +++ b/drivers/usb/host/xhci.h > @@ -1656,6 +1656,9 @@ struct xhci_hcd { > #define XHCI_SSIC_PORT_UNUSED (1 << 22) > #define XHCI_NO_64BIT_SUPPORT (1 << 23) > #define XHCI_MISSING_CAS (1 << 24) > +/* For controller with a broken Port Disable implementation */ > +#define XHCI_BROKEN_PORT_PED (1 << 21) since back when I first wrote this, bit 21 has been taken. You should be using bit 25 here. =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAlgy4NAACgkQzL64meEa mQYO1Q/+Ozn8dmmf1fOz0+7LbQEHaZUS1pq5+W27xtdZbtfruByQafFviFc7APKy WSm+7u1Xe29ZQWf5ZPlExaPuMsi37CHNszp2BH4ApJ96HzUXTQVj7bRmytORPEur P3OImVfTFT9iW7XWqH+JPY7qLJJhwPoHrjZtpKS+WWJ886XiSWIiC6RhM1yA+nNr kxtAAGxhl4frH+nqSQcYRfoP8v/Gt7N3UJew6xq4ZbctojmSzcCHWuwYe/1eGX6y oSYiCnVlGQweY/zxDdWfU1HdeZ0IiH5MtlWbZ7Np7zyQxBlpDwo0v/OKHs2AT4W5 0GDvQLL4+0MVv+hqzXTLab2S7gl0U/OkBzz4QD4ERi8KwDQOIzNDB0TMA3Radn5g IcHSZ6opwU39qQTNKDsYHQcUFwjtD3kbHS/f9lJ2iZtXwHrWb5kzaDEHECOfgQt3 3fETGwbhcq3+PDmLarVA0V2flVZmfN72cvLkhlX9JJpBA7k5jb9g9RB76aNND42P BEki21daXJJCmCI5xmw8bRXlZyuQbVgNAkmKgMYakKhOVy9pYeGrx5lMGv6yEllu XLCduRU/4d39cFilY1Q7GTJ0Ixqzef5hn/W9N2ku/1byGFJRMijzhpRf/+KJWfCT sULJSc9ku0ZP5tFhe6jgm0HeQ/R9m9L6+RTdZzj6t7pap+pikRM= =2M4Y -----END PGP SIGNATURE----- --=-=-=--