Re: [PATCH v2 net-next v2 09/12] net: dsa: mv88e6xxx: add SMI detection helper

Vivien Didelot
2016-06-14T22:10:59Z

Hi Andrew,

Andrew Lunn <andrew@lunn.ch> writes:

>> - name = info->name;
>> + dev_info(dev, "switch 0x%x detected: %s, revision %u\n", prod_num,
>> + info->name, rev);
>>
>> - ps = devm_kzalloc(dsa_dev, sizeof(*ps), GFP_KERNEL);
>> + ps = devm_kzalloc(dev, sizeof(*ps), GFP_KERNEL);
>> if (!ps)
>> return NULL;
>
> I don't like the way this detect function goes a lot further than
> detection. I would say detection finished when you have the info
> structure. Return at that point, and let the probe do the rest.

OK, I split detection and allocation.

Thanks,

Vivien