From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933855AbcCOW5M (ORCPT ); Tue, 15 Mar 2016 18:57:12 -0400 Received: from smtp04.smtpout.orange.fr ([80.12.242.126]:37740 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751131AbcCOW5J (ORCPT ); Tue, 15 Mar 2016 18:57:09 -0400 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Tue, 15 Mar 2016 23:57:06 +0100 X-ME-IP: 109.220.88.99 From: Robert Jarzmik To: David Miller Cc: Fabio Estevam , Guennadi Liakhovetski , Hitoshi Mitake , Fabio Estevam , Hitoshi Mitake , "netdev\@vger.kernel.org" , LKML Subject: Re: [PATCH] net: smc911x: convert pxa dma to dmaengine References: <20151202.235217.2201517065767030121.davem@davemloft.net> <87fuzjl69l.fsf@belgarion.home> <87k2mi4ysn.fsf@belgarion.home> <20160205.173021.1388372628450225378.davem@davemloft.net> <87fux6439s.fsf@belgarion.home> <8760xjzbc5.fsf@belgarion.home> <87lh5zpbaw.fsf@belgarion.home> X-URL: http://belgarath.falguerolles.org/ Date: Tue, 15 Mar 2016 23:56:58 +0100 In-Reply-To: <87lh5zpbaw.fsf@belgarion.home> (Robert Jarzmik's message of "Thu, 03 Mar 2016 21:16:07 +0100") Message-ID: <87wpp3mjt1.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Robert Jarzmik writes: > Fabio Estevam writes: >> Tested-by: Fabio Estevam > > Thanks Fabio for the test. > > I also tried with a different different approach. > > I built the different platforms (imx v6, etc ...) : > - one version (a) on a vanilla v4.5-rc2 > - one version (b) on a vaniall v4.5-rc2 + this patch > > For each of the builds, I took the preprocessed output of smc911x.c, and made a > diff between (a) and (b). The commands used were : > - building in [1] > - diffing in [2] > > The result is [3]. I conclude from [3] that the driver cannot break for non PXA > platforms. > > With Fabio's test and this demonstration, is enough to convince you to apply > this patch David ? Hi David, Can you consider this patch now it is tested please ? -- Robert