From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965203AbcBCRyN (ORCPT ); Wed, 3 Feb 2016 12:54:13 -0500 Received: from mail-lf0-f48.google.com ([209.85.215.48]:34669 "EHLO mail-lf0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965171AbcBCRyJ (ORCPT ); Wed, 3 Feb 2016 12:54:09 -0500 From: Felipe Balbi To: Bin Liu , Arnd Bergmann Cc: Felipe Balbi , balbif@gmail.com, Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: phy-am335x: clarify USB_COMMON dependency In-Reply-To: <20160120180833.GA5433@uda0271908> References: <1749004.q1rSF7t8cz@wuerfel> <20160120180833.GA5433@uda0271908> User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/25.0.90.1 (x86_64-pc-linux-gnu) Date: Wed, 03 Feb 2016 19:54:02 +0200 Message-ID: <87wpqlptmt.fsf@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable hi, Bin Liu writes: > On Wed, Jan 20, 2016 at 11:56:34AM +0100, Arnd Bergmann wrote: >> The phy-am335x driver accidentally selects 'USB_COMMON', which is >> not correct as that symbol should indicate whether USB host or >> target mode is enabled, but it might not: >>=20 >> warning: (AM335X_PHY_USB) selects USB_COMMON which has unmet direct depe= ndencies (USB_SUPPORT && (USB || USB_GADGET)) > > Is it possible to have a .config which has either USB nor USB_GADGET > set but AM335X_PHY_USB is set to be in the situation as in the warning > above? > >>=20 >> This changes the 'select' into 'depends on', as it should have >> been initially. > > Using 'depends on' causes AM335x_PHY_USB driver unable to built-in, > since USB_COMMON is an invisible option and its defualt is 'M'. yeah, USB_COMMON is supposed to be selected, not depended upon. =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWsj67AAoJEIaOsuA1yqREoXUP/2qlPoFXK9/0bl/ZHtMRRVr2 c808YYACYLeoeU3Z1tPB0yZmwtIz6ULlZS7KaS0D+iCxbjrd15FxIobVrERfFBTE 6k5nOM73BVxL0kAZ2lBmubz1/Z2sVik7mOWsnSBpb32J6yN8bNB8d3zWkHSmH5pu XY3CehvKrdcOpiOvh8H7nRpXpxuezrtaylliKbge7PlQGw9hTWTX8RVo92NiS+8i yLf2PExXO2BBFwtTq9JLlZf+dqWWHU8UvDFi0B3oidn1/ijY/FOP1z7v89/mwReP npzKVKN6CRCiJATnMVh3pa0yRQiAnXnot80HMFsDl3qAZZS55hZHyWCTa/XFmY2T x749xwBf5pKj2Xb5CHXzdmMPWI/pxzyrgiCdwq5C42MJ0YvllwXWAwUS5wkK/DEB smHVWMlMEmZMPDAN6T8A3UVRUjQKDo+d26gXjHu0lBsRJAbu9WeRHwVDGX79n1XB Fu85aXRC2mJurCaIZk7vhAcCDlwOTtOIvHTADhgM4L5oSDP444Z8KyL3r9iauu8F FPnckeRRdM4PiIYTJxxCFl28LSnJVNULaeUwR2sYVEt9MZ3m/lhXtL8fTtTD51RS gIPYMSw+jfE8gcCAtkIOBO8xW1Eupb44kWjatNnSLTiXHedqFZBY6vjZTol3IH22 jS6N4ANVDAeCZHznYgmH =xhSc -----END PGP SIGNATURE----- --=-=-=--