Re: [PATCH V4] usb: remove unnecessary CONFIG_PM dependency from USB_OTG

[Felipe Balbi <balbi@ti.com>]

[-- Attachment #1: Type: text/plain, Size: 1382 bytes --]


Hi,

Nathan Sullivan <nathan.sullivan@ni.com> writes:
> On Tue, Nov 03, 2015 at 07:56:55AM -0600, Felipe Balbi wrote:
>> 
>> Hi,
>> 
>> Nathan Sullivan <nathan.sullivan@ni.com> writes:
>> > The USB OTG support currently depends on power management
>> > (CONFIG_PM) being enabled, but does not actually need it enabled.
>> > Remove this dependency.
>> >
>> > Tested on Bay Trail hardware with dwc3 USB.
>> >
>> > Signed-off-by: Nathan Sullivan <nathan.sullivan@ni.com>
>> > ---
>> >  drivers/usb/core/Kconfig |    1 -
>> >  1 file changed, 1 deletion(-)
>> >
>> > diff --git a/drivers/usb/core/Kconfig b/drivers/usb/core/Kconfig
>> > index a99c89e..9c5cdf3 100644
>> > --- a/drivers/usb/core/Kconfig
>> > +++ b/drivers/usb/core/Kconfig
>> > @@ -43,7 +43,6 @@ config USB_DYNAMIC_MINORS
>> >  
>> >  config USB_OTG
>> >  	bool "OTG support"
>> > -	depends on PM
>> 
>> I don't think this is correct. OTG depends on USB bus suspend, which is
>> only available on PM builds. Care to further detail why you think PM is
>> not needed on OTG ?
>> 
>> -- 
>> balbi
>
> I think we can drop this patch, actually.
>
> It looks like we confused gadget and OTG support at some point in the
> past, and we don't want PM on our hardware for latency reasons.  We
> really only need USB gadget support, not full OTG.

Fair enough, thank you

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]