From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752046AbbHMIxI (ORCPT ); Thu, 13 Aug 2015 04:53:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45584 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751129AbbHMIxE (ORCPT ); Thu, 13 Aug 2015 04:53:04 -0400 From: Vitaly Kuznetsov To: "James E.J. Bottomley" Cc: KY Srinivasan , "linux-scsi\@vger.kernel.org" , Haiyang Zhang , "devel\@linuxdriverproject.org" , "linux-kernel\@vger.kernel.org" , Long Li Subject: Re: [PATCH] scsi: storvsc: use shost_for_each_device() instead of open coding References: <1435743087-7824-1-git-send-email-vkuznets@redhat.com> Date: Thu, 13 Aug 2015 10:53:00 +0200 In-Reply-To: (Long Li's message of "Fri, 3 Jul 2015 19:44:16 +0000") Message-ID: <87wpwzefir.fsf@vitty.brq.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Long Li writes: >> -----Original Message----- >> From: KY Srinivasan >> Sent: Friday, July 03, 2015 11:35 AM >> To: Vitaly Kuznetsov; linux-scsi@vger.kernel.org >> Cc: Long Li; Haiyang Zhang; James E.J. Bottomley; devel@linuxdriverproject.org; >> linux-kernel@vger.kernel.org >> Subject: RE: [PATCH] scsi: storvsc: use shost_for_each_device() instead of open >> coding >> >> >> >> > -----Original Message----- >> > From: Vitaly Kuznetsov [mailto:vkuznets@redhat.com] >> > Sent: Wednesday, July 1, 2015 2:31 AM >> > To: linux-scsi@vger.kernel.org >> > Cc: Long Li; KY Srinivasan; Haiyang Zhang; James E.J. Bottomley; >> > devel@linuxdriverproject.org; linux-kernel@vger.kernel.org >> > Subject: [PATCH] scsi: storvsc: use shost_for_each_device() instead of >> > open coding >> > >> > Comment in struct Scsi_Host says that drivers are not supposed to >> > access __devices directly. storvsc_host_scan() doesn't happen in irq >> > context so we can just use shost_for_each_device(). >> > >> > Signed-off-by: Vitaly Kuznetsov >> >> Signed-off-by: K. Y. Srinivasan > Reviewed-by: Long Li Sorry for the ping but it seems the fix never made it to scsi tree... >> > --- >> > drivers/scsi/storvsc_drv.c | 9 +-------- >> > 1 file changed, 1 insertion(+), 8 deletions(-) >> > >> > diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c >> > index 3c6584f..9ea912b 100644 >> > --- a/drivers/scsi/storvsc_drv.c >> > +++ b/drivers/scsi/storvsc_drv.c >> > @@ -426,7 +426,6 @@ static void storvsc_host_scan(struct work_struct >> > *work) >> > struct storvsc_scan_work *wrk; >> > struct Scsi_Host *host; >> > struct scsi_device *sdev; >> > - unsigned long flags; >> > >> > wrk = container_of(work, struct storvsc_scan_work, work); >> > host = wrk->host; >> > @@ -443,14 +442,8 @@ static void storvsc_host_scan(struct work_struct >> > *work) >> > * may have been removed this way. >> > */ >> > mutex_lock(&host->scan_mutex); >> > - spin_lock_irqsave(host->host_lock, flags); >> > - list_for_each_entry(sdev, &host->__devices, siblings) { >> > - spin_unlock_irqrestore(host->host_lock, flags); >> > + shost_for_each_device(sdev, host) >> > scsi_test_unit_ready(sdev, 1, 1, NULL); >> > - spin_lock_irqsave(host->host_lock, flags); >> > - continue; >> > - } >> > - spin_unlock_irqrestore(host->host_lock, flags); >> > mutex_unlock(&host->scan_mutex); >> > /* >> > * Now scan the host to discover LUNs that may have been added. >> > -- >> > 2.4.3 -- Vitaly