Re: [RFC 11/32] xfs: convert to struct inode_time

Roger Willcocks
2014-06-03T13:09:49Z

On Mon, 2014-06-02 at 19:32 -0400, Theodore Ts'o wrote:

> Linux's time(2) can return (time_t) -1 and set errno to EFAULT, per
> the Posix specification:
>
> SYSCALL_DEFINE1(time, time_t __user *, tloc)
> {
> time_t i = get_seconds();
>
> if (tloc) {
> if (put_user(i,tloc))
> return -EFAULT;
> }
> force_successful_syscall_return();
> return i;
> }

get_seconds() returns an unsigned long so there's potential for overflow
here.

--
Roger