From: Marc Zyngier <marc.zyngier@arm.com>
To: Feng Kan <fkan@apm.com>
Cc: "tglx\@linutronix.de" <tglx@linutronix.de>,
Catalin Marinas <Catalin.Marinas@arm.com>,
Will Deacon <Will.Deacon@arm.com>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"patches\@apm.com" <patches@apm.com>,
Vinayak Kale <vkale@apm.com>
Subject: Re: [PATCH 2/2] irqchip: gic: preserve gic V2 bypass bits in cpu ctrl register
Date: Tue, 20 May 2014 10:14:05 +0100 [thread overview]
Message-ID: <87wqdg3j8i.fsf@approximate.cambridge.arm.com> (raw)
In-Reply-To: <CAL85gmByuxTdPWaDZENDz=rKQtfZc44eUaCsnK04DfeXknAoYg@mail.gmail.com> (Feng Kan's message of "Tue, 20 May 2014 02:26:33 +0100")
On Tue, May 20 2014 at 2:26:33 am BST, Feng Kan <fkan@apm.com> wrote:
>>> #ifdef CONFIG_CPU_PM
>>> @@ -613,7 +636,7 @@ static void gic_cpu_restore(unsigned int gic_nr)
>>> dist_base + GIC_DIST_PRI + i * 4);
>>>
>>> writel_relaxed(GIC_INT_PRI_THRESHOLD, cpu_base + GIC_CPU_PRIMASK);
>>> - writel_relaxed(GIC_CPU_ENABLE, cpu_base + GIC_CPU_CTRL);
>>> + gic_cpu_if_up();
>>
>> Have you tested the save/restore path? It seems that we dont save
>> GICC_CTLR, so it may not do what you think it will...
>
> We are debating which is the better method. Currently we are only
> disabling the GIC distributor so it is not a problem. Later on, with
> more aggressive PM we could have the helper core to setup the GIC CTLR
> prior to releasing out of the PM state. However, it seems it would be
> more cleaner if we save off the GIC_CTLR bits in the
> gic_cpu_save. This would add additional items in to the
> gic_chip_data. Would you be open to that?
I'm open to anything that looks reasonable and doesn't introduce
regressions. Saving/restoring the CPU interface state should be fine.
M.
--
Jazz is not dead. It just smells funny.
prev parent reply other threads:[~2014-05-20 9:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1400278813-3048-1-git-send-email-fkan@apm.com>
[not found] ` <1400278813-3048-2-git-send-email-fkan@apm.com>
2014-05-19 9:13 ` [PATCH 1/2] irqchip: gic: replace hex numbers with defines Marc Zyngier
[not found] ` <1400278813-3048-3-git-send-email-fkan@apm.com>
2014-05-19 9:42 ` [PATCH 2/2] irqchip: gic: preserve gic V2 bypass bits in cpu ctrl register Marc Zyngier
2014-05-20 1:26 ` Feng Kan
2014-05-20 9:14 ` Marc Zyngier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wqdg3j8i.fsf@approximate.cambridge.arm.com \
--to=marc.zyngier@arm.com \
--cc=Catalin.Marinas@arm.com \
--cc=Will.Deacon@arm.com \
--cc=fkan@apm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@apm.com \
--cc=tglx@linutronix.de \
--cc=vkale@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox