From: Kevin Hilman <khilman@linaro.org>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Christoph Lameter <cl@linux.com>,
Hakan Akkan <hakanakkan@gmail.com>,
Li Zhong <zhong@linux.vnet.ibm.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Peter Zijlstra <peterz@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 1/2] nohz: Select VIRT_CPU_ACCOUNTING_GEN from full dynticks config
Date: Mon, 13 May 2013 14:16:14 -0700 [thread overview]
Message-ID: <87wqr21syp.fsf@linaro.org> (raw)
In-Reply-To: <1366988007-30665-2-git-send-email-fweisbec@gmail.com> (Frederic Weisbecker's message of "Fri, 26 Apr 2013 16:53:26 +0200")
Frederic Weisbecker <fweisbec@gmail.com> writes:
> Turn the full dynticks passive dependency on VIRT_CPU_ACCOUNTING_GEN
> to an active one.
[...]
> @@ -329,7 +329,7 @@ config VIRT_CPU_ACCOUNTING_NATIVE
>
> config VIRT_CPU_ACCOUNTING_GEN
> bool "Full dynticks CPU time accounting"
> - depends on HAVE_CONTEXT_TRACKING && 64BIT
> + depends on HAVE_CONTEXT_TRACKING && 64BIT && NO_HZ_FULL
> select VIRT_CPU_ACCOUNTING
> select CONTEXT_TRACKING
> help
Existing 64-bit dependency is here...
> diff --git a/kernel/time/Kconfig b/kernel/time/Kconfig
> index 1ea2bba..a2ddd65 100644
> --- a/kernel/time/Kconfig
> +++ b/kernel/time/Kconfig
> @@ -104,11 +104,13 @@ config NO_HZ_FULL
> depends on SMP
> # RCU_USER_QS dependency
> depends on HAVE_CONTEXT_TRACKING
> - depends on VIRT_CPU_ACCOUNTING_GEN
> + # VIRT_CPU_ACCOUNTING_GEN dependency
> + depends on 64BIT
...and another one added here?
Is there a new 64-bit dependency in NO_HZ_FULL not covered by the one
already in VIRT_CPU_ACCOUNTING_GEN? Or do you have reasons to be doubly
paranoid about the non 64-bit usage? ;)
Kevin
next prev parent reply other threads:[~2013-05-13 21:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-26 14:53 [GIT PULL] nohz: A few improvements Frederic Weisbecker
2013-04-26 14:53 ` [PATCH 1/2] nohz: Select VIRT_CPU_ACCOUNTING_GEN from full dynticks config Frederic Weisbecker
2013-04-26 15:39 ` Paul E. McKenney
2013-04-26 16:22 ` Frederic Weisbecker
2013-04-26 23:01 ` Frederic Weisbecker
2013-04-27 7:19 ` Ingo Molnar
2013-05-13 21:16 ` Kevin Hilman [this message]
2013-04-26 14:53 ` [PATCH 2/2] cputime_nsecs: use math64.h for nsec resolution conversion helpers Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wqr21syp.fsf@linaro.org \
--to=khilman@linaro.org \
--cc=cl@linux.com \
--cc=fweisbec@gmail.com \
--cc=hakanakkan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=zhong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox