Re: [PATCH] virtio-blk: emit udev event when device is resized

Greg KH
2013-02-25T22:43:43Z

On Mon, Feb 25, 2013 at 11:39:52PM +0100, Kay Sievers wrote:
> On Mon, Feb 25, 2013 at 11:12 PM, Greg KH <greg@kroah.com> wrote:
>
> > Hm, I thought we were frowning apon running binaries from udev rules
> > these days, especially ones that might have big consequences (like
> > resizing a disk image) like this.
> >
> > Kay, am I right?
>
> We removed most of them from the default setups, yes. But there is
> nothing wrong if people want to ship that in some package or as custom
> rules.
>
> It looks fine to me, we would just not add such things to the default
> set of of rules these days.
>
> > We already emit KOBJECT_CHANGE events when block devices change, from
> > within the block core code. Why is the patch below needed instead of
> > using these events that are already generated? How are virtio block
> > devices special?
>
> I think we only do that for dm and md and a couple of special cases
> like loop and read-only settings.

What about when we repartition a block device? I've seen the events
happen then.

Anyway, if you are ok with this, no objection from my side then Rusty.

thanks,

greg k-h