* [PATCH 2/2] fat: Fix bug in enforcing Long File Name length.
@ 2012-03-03 1:16 Namjae Jeon
2012-03-03 20:59 ` OGAWA Hirofumi
0 siblings, 1 reply; 4+ messages in thread
From: Namjae Jeon @ 2012-03-03 1:16 UTC (permalink / raw)
To: hirofumi; +Cc: linux-kernel, Namjae Jeon, Ravishankar N
Since '*outlen' is initialized to zero,it is currently possible to create a f ilename of length (FAT_LFN_LEN +1) when utf8 is not enabled.To enforce the FA T_LFN_LEN limit, we must perform one less iteration.
Signed-off-by: Namjae Jeon <linkinjeon@gmail.com>
Signed-off-by: Ravishankar N <cyberax82@gmail.com>
---
fs/fat/namei_vfat.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/fat/namei_vfat.c b/fs/fat/namei_vfat.c
index aae3b4e..98ae804 100644
--- a/fs/fat/namei_vfat.c
+++ b/fs/fat/namei_vfat.c
@@ -522,7 +522,7 @@ xlate_to_uni(const unsigned char *name, int len, unsigned char *outname,
op = &outname[*outlen * sizeof(wchar_t)];
} else {
for (i = 0, ip = name, op = outname, *outlen = 0;
- i < len && *outlen <= FAT_LFN_LEN;
+ i < len && *outlen < FAT_LFN_LEN;
*outlen += 1) {
if (escape && (*ip == ':')) {
if (i > len - 5)
--
1.7.5.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 2/2] fat: Fix bug in enforcing Long File Name length.
2012-03-03 1:16 [PATCH 2/2] fat: Fix bug in enforcing Long File Name length Namjae Jeon
@ 2012-03-03 20:59 ` OGAWA Hirofumi
2012-03-03 21:07 ` OGAWA Hirofumi
2012-03-04 5:20 ` Namjae Jeon
0 siblings, 2 replies; 4+ messages in thread
From: OGAWA Hirofumi @ 2012-03-03 20:59 UTC (permalink / raw)
To: Namjae Jeon; +Cc: linux-kernel, Ravishankar N, Andrew Morton
Namjae Jeon <linkinjeon@gmail.com> writes:
> Since '*outlen' is initialized to zero,it is currently possible to create a f ilename of length (FAT_LFN_LEN +1) when utf8 is not enabled.To enforce the FA T_LFN_LEN limit, we must perform one less iteration.
Acked-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
> Signed-off-by: Namjae Jeon <linkinjeon@gmail.com>
> Signed-off-by: Ravishankar N <cyberax82@gmail.com>
> ---
> fs/fat/namei_vfat.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/fat/namei_vfat.c b/fs/fat/namei_vfat.c
> index aae3b4e..98ae804 100644
> --- a/fs/fat/namei_vfat.c
> +++ b/fs/fat/namei_vfat.c
> @@ -522,7 +522,7 @@ xlate_to_uni(const unsigned char *name, int len, unsigned char *outname,
> op = &outname[*outlen * sizeof(wchar_t)];
> } else {
> for (i = 0, ip = name, op = outname, *outlen = 0;
> - i < len && *outlen <= FAT_LFN_LEN;
> + i < len && *outlen < FAT_LFN_LEN;
> *outlen += 1) {
> if (escape && (*ip == ':')) {
> if (i > len - 5)
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 2/2] fat: Fix bug in enforcing Long File Name length.
2012-03-03 20:59 ` OGAWA Hirofumi
@ 2012-03-03 21:07 ` OGAWA Hirofumi
2012-03-04 5:20 ` Namjae Jeon
1 sibling, 0 replies; 4+ messages in thread
From: OGAWA Hirofumi @ 2012-03-03 21:07 UTC (permalink / raw)
To: Namjae Jeon; +Cc: linux-kernel, Ravishankar N, Andrew Morton
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> writes:
> Namjae Jeon <linkinjeon@gmail.com> writes:
>
>> Since '*outlen' is initialized to zero,it is currently possible to
>> create a f ilename of length (FAT_LFN_LEN +1) when utf8 is not
>> enabled.To enforce the FA T_LFN_LEN limit, we must perform one less
>> iteration.
>
> Acked-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Please forward this too.
>> Signed-off-by: Namjae Jeon <linkinjeon@gmail.com>
>> Signed-off-by: Ravishankar N <cyberax82@gmail.com>
>> ---
>> fs/fat/namei_vfat.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/fs/fat/namei_vfat.c b/fs/fat/namei_vfat.c
>> index aae3b4e..98ae804 100644
>> --- a/fs/fat/namei_vfat.c
>> +++ b/fs/fat/namei_vfat.c
>> @@ -522,7 +522,7 @@ xlate_to_uni(const unsigned char *name, int len, unsigned char *outname,
>> op = &outname[*outlen * sizeof(wchar_t)];
>> } else {
>> for (i = 0, ip = name, op = outname, *outlen = 0;
>> - i < len && *outlen <= FAT_LFN_LEN;
>> + i < len && *outlen < FAT_LFN_LEN;
>> *outlen += 1) {
>> if (escape && (*ip == ':')) {
>> if (i > len - 5)
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 2/2] fat: Fix bug in enforcing Long File Name length.
2012-03-03 20:59 ` OGAWA Hirofumi
2012-03-03 21:07 ` OGAWA Hirofumi
@ 2012-03-04 5:20 ` Namjae Jeon
1 sibling, 0 replies; 4+ messages in thread
From: Namjae Jeon @ 2012-03-04 5:20 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel, Ravishankar N, OGAWA Hirofumi
Hi. Andrew.
Would you plz check this patch also ?
Thanks.
2012/3/4 OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>:
> Namjae Jeon <linkinjeon@gmail.com> writes:
>
>> Since '*outlen' is initialized to zero,it is currently possible to create a f ilename of length (FAT_LFN_LEN +1) when utf8 is not enabled.To enforce the FA T_LFN_LEN limit, we must perform one less iteration.
>
> Acked-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
>
>> Signed-off-by: Namjae Jeon <linkinjeon@gmail.com>
>> Signed-off-by: Ravishankar N <cyberax82@gmail.com>
>> ---
>> fs/fat/namei_vfat.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/fs/fat/namei_vfat.c b/fs/fat/namei_vfat.c
>> index aae3b4e..98ae804 100644
>> --- a/fs/fat/namei_vfat.c
>> +++ b/fs/fat/namei_vfat.c
>> @@ -522,7 +522,7 @@ xlate_to_uni(const unsigned char *name, int len, unsigned char *outname,
>> op = &outname[*outlen * sizeof(wchar_t)];
>> } else {
>> for (i = 0, ip = name, op = outname, *outlen = 0;
>> - i < len && *outlen <= FAT_LFN_LEN;
>> + i < len && *outlen < FAT_LFN_LEN;
>> *outlen += 1) {
>> if (escape && (*ip == ':')) {
>> if (i > len - 5)
>
> --
> OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-03-04 5:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-03 1:16 [PATCH 2/2] fat: Fix bug in enforcing Long File Name length Namjae Jeon
2012-03-03 20:59 ` OGAWA Hirofumi
2012-03-03 21:07 ` OGAWA Hirofumi
2012-03-04 5:20 ` Namjae Jeon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox