Re: [PATCH v6] fat: Batched discard support for fat

[OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>]

Kyungmin Park <kmpark@infradead.org> writes:

> Hi again,

Hi

> Do you still object to merge this feature for .40? As I said the
> batched discard design is out-of-scope of this patch.
> It's implemented at other batched discard, ext4, xfs and so on.
>
> I hope fat is also support the batched discard.
>
> Any opinions?

I'm also thinking implementing this is good though. Sorry, I'm not going
to apply this for now, and would like to wait to be used by real
userland (I hope guys notice the problem, or userland tackles it somehow
sadly).

I think, to expose the wrong behavior like this would be worse.

E.g. one of problems, userland might do like this (trim chunk from 0 to
number of block)

for chunk in number_of_blocks
	do_trim chunk
done

But this is actually wrong, this interface doesn't map blocks to 0-max,
so userland have to know real maximum-block-number somehow for each FS
(and maybe have to know real minimum-block-number).

So, how to fix this? The solutions would be userland workaround, or fix
kernel. If it was userland, userland have to know FS internal sadly. If
it was kernel, we would have backward compatible nightmare, or ignore
compatible :(.

I really think we have to rethink this and have agreement about common
interface. Or there was real userland app, I think FAT can implement to
work that app.

Thanks.
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>