public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: James Kosin <jkosin@intcomgrp.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [OT] Style Issues / Concerns
Date: Mon, 22 Mar 2010 21:13:06 +0100	[thread overview]
Message-ID: <87wrx45d4d.fsf@basil.nowhere.org> (raw)
In-Reply-To: <4BA7CCC5.5020302@intcomgrp.com> (James Kosin's message of "Mon, 22 Mar 2010 16:02:13 -0400")

James Kosin <jkosin@intcomgrp.com> writes:
>
> Before everyone jumps in at once, this is a simple example that will
> produce a compiler error about the misplaced else.  However if there are
> many if statements above this that may allow the else to be paired up
> with it then the code will compile and there will be a serious and very
> difficult bug in the code that will take days or months to find.

Modern editors with auto indent mode makes it actually very easy
to find such bugs.

Also checkpatch.pl checks for it now I believe.

> Does the compiler produce smaller code without the braces {}?

No, it's very arbitary.

-Andi

-- 
ak@linux.intel.com -- Speaking for myself only.

  reply	other threads:[~2010-03-22 20:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-22 20:02 [OT] Style Issues / Concerns James Kosin
2010-03-22 20:13 ` Andi Kleen [this message]
2010-03-22 20:33   ` James Kosin
2010-03-22 20:55     ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wrx45d4d.fsf@basil.nowhere.org \
    --to=andi@firstfloor.org \
    --cc=jkosin@intcomgrp.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox