From: Andi Kleen <andi@firstfloor.org>
To: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Cc: Ingo Molnar <mingo@elte.hu>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] task_struct: stack_canary is not needed without CC_STACKPROTECTOR
Date: Tue, 18 Aug 2009 09:34:38 +0200 [thread overview]
Message-ID: <87ws51r2wh.fsf@basil.nowhere.org> (raw)
In-Reply-To: <4A8A44CA.2020701@ct.jp.nec.com> (Hiroshi Shimamoto's message of "Tue, 18 Aug 2009 15:06:02 +0900")
Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> writes:
> From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
>
> The field stack_canary is only used with CC_STACKPROTECTOR.
> This patch reduces task_struct size without CC_STACKPROTECTOR.
Adding a ifdef in the middle of a widely used structure is nasty. It
means that if someone changes the option then the newly loaded modules
don't work anymore (yes that's not officially supported, but works
most of the time and is often convenient in practice)
So when you add a ifdef please move the field to the end at least.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2009-08-18 7:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-18 6:06 [PATCH] task_struct: stack_canary is not needed without CC_STACKPROTECTOR Hiroshi Shimamoto
2009-08-18 7:34 ` Andi Kleen [this message]
2009-08-18 8:01 ` [PATCH v2] " Hiroshi Shimamoto
2009-08-18 13:43 ` Ingo Molnar
2009-08-18 13:48 ` [tip:sched/core] sched, " tip-bot for Hiroshi Shimamoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ws51r2wh.fsf@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=h-shimamoto@ct.jp.nec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox