public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [FIX REQUEST] Need better management for include/linux/*.h
@ 2009-07-11  9:18 Jaswinder Singh Rajput
  2009-07-12  8:00 ` Avi Kivity
  2009-07-12  8:51 ` Andi Kleen
  0 siblings, 2 replies; 4+ messages in thread
From: Jaswinder Singh Rajput @ 2009-07-11  9:18 UTC (permalink / raw)
  To: nicolas.ferre, hskinnemoen, Avi Kivity, kvm, LKML

Hello all,

As include/linux/*.h file count is going to reach 1000.

We need to do some better techniques to reduce the number of files and
add some hierarchy levels like sub directories where possible.

Like atmel is not exporting to user-space we can easily do :

include/linux/atmel-mci.h     -> include/linux/atmel/mci.h
include/linux/atmel_pdc.h     -> include/linux/atmel/pdc.h
include/linux/atmel-pwm-bl.h  -> include/linux/atmel/pwm-bl.h
include/linux/atmel_pwm.h     -> include/linux/atmel/pwm.h
include/linux/atmel_serial.h  -> include/linux/atmel/serial.h
include/linux/atmel-ssc.h     -> include/linux/atmel/ssc.h
include/linux/atmel_tc.h      -> include/linux/atmel/tc.h

Also these files are not exporting :

include/linux/kvm_host.h      -> include/linux/kvm/host.h
include/linux/kvm_para.h      -> include/linux/kvm/para.h
include/linux/kvm_types.h     -> include/linux/kvm/types.h

Similarly for other files, where possible.

Thanks,
--
JSR




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [FIX REQUEST] Need better management for include/linux/*.h
  2009-07-11  9:18 [FIX REQUEST] Need better management for include/linux/*.h Jaswinder Singh Rajput
@ 2009-07-12  8:00 ` Avi Kivity
  2009-07-27 11:54   ` Haavard Skinnemoen
  2009-07-12  8:51 ` Andi Kleen
  1 sibling, 1 reply; 4+ messages in thread
From: Avi Kivity @ 2009-07-12  8:00 UTC (permalink / raw)
  To: Jaswinder Singh Rajput; +Cc: nicolas.ferre, hskinnemoen, kvm, LKML

On 07/11/2009 12:18 PM, Jaswinder Singh Rajput wrote:
> Hello all,
>
> As include/linux/*.h file count is going to reach 1000.
>
> We need to do some better techniques to reduce the number of files and
> add some hierarchy levels like sub directories where possible.
>
> Like atmel is not exporting to user-space we can easily do :
>
> include/linux/atmel-mci.h     ->  include/linux/atmel/mci.h
> include/linux/atmel_pdc.h     ->  include/linux/atmel/pdc.h
> include/linux/atmel-pwm-bl.h  ->  include/linux/atmel/pwm-bl.h
> include/linux/atmel_pwm.h     ->  include/linux/atmel/pwm.h
> include/linux/atmel_serial.h  ->  include/linux/atmel/serial.h
> include/linux/atmel-ssc.h     ->  include/linux/atmel/ssc.h
> include/linux/atmel_tc.h      ->  include/linux/atmel/tc.h
>
> Also these files are not exporting :
>
> include/linux/kvm_host.h      ->  include/linux/kvm/host.h
> include/linux/kvm_para.h      ->  include/linux/kvm/para.h
> include/linux/kvm_types.h     ->  include/linux/kvm/types.h
>
>    

IMO a much better move is to place non-ABI files (and the #ifdef KERNEL 
parts of ABI files) outside include/linux.


-- 
error compiling committee.c: too many arguments to function


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [FIX REQUEST] Need better management for include/linux/*.h
  2009-07-11  9:18 [FIX REQUEST] Need better management for include/linux/*.h Jaswinder Singh Rajput
  2009-07-12  8:00 ` Avi Kivity
@ 2009-07-12  8:51 ` Andi Kleen
  1 sibling, 0 replies; 4+ messages in thread
From: Andi Kleen @ 2009-07-12  8:51 UTC (permalink / raw)
  To: Jaswinder Singh Rajput; +Cc: nicolas.ferre, hskinnemoen, Avi Kivity, kvm, LKML

Jaswinder Singh Rajput <jaswinder@kernel.org> writes:

> Hello all,
>
> As include/linux/*.h file count is going to reach 1000.
>
> We need to do some better techniques to reduce the number of files and
> add some hierarchy levels like sub directories where possible.

Why? 100 or 1000 really doesn't make much difference; in both
cases you cannot easily browse and have to use tab completion.
And I doubt your reorganization would go below 100.

I would just leave it as it is.

-Andi
-- 
ak@linux.intel.com -- Speaking for myself only.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [FIX REQUEST] Need better management for include/linux/*.h
  2009-07-12  8:00 ` Avi Kivity
@ 2009-07-27 11:54   ` Haavard Skinnemoen
  0 siblings, 0 replies; 4+ messages in thread
From: Haavard Skinnemoen @ 2009-07-27 11:54 UTC (permalink / raw)
  To: Avi Kivity; +Cc: Jaswinder Singh Rajput, nicolas.ferre, hskinnemoen, kvm, LKML

Avi Kivity wrote:
> IMO a much better move is to place non-ABI files (and the #ifdef KERNEL 
> parts of ABI files) outside include/linux.

How about adding a new include/soc directory and move them all there
(along with similar header files from other SoC vendors)?

Haavard

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2009-07-27 12:00 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-11  9:18 [FIX REQUEST] Need better management for include/linux/*.h Jaswinder Singh Rajput
2009-07-12  8:00 ` Avi Kivity
2009-07-27 11:54   ` Haavard Skinnemoen
2009-07-12  8:51 ` Andi Kleen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox