From: Andi Kleen <andi@firstfloor.org>
To: David Woodhouse <dwmw2@infradead.org>
Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: Misc fixes for 2.6.27
Date: Tue, 02 Sep 2008 00:32:16 +0200 [thread overview]
Message-ID: <87wshvwl8v.fsf@basil.nowhere.org> (raw)
In-Reply-To: <1220300084.2982.139.camel@pmac.infradead.org> (David Woodhouse's message of "Mon, 01 Sep 2008 21:14:44 +0100")
David Woodhouse <dwmw2@infradead.org> writes:
> +
> +static struct dmi_system_id __initdata intel_iommu_dmi_table[] = {
> + { /* Some DG33BU BIOS revisions advertised non-existent VT-d */
Are you sure it's non existent? A G33 chipset should have it in
hardware I thought.
I'm not sure this is really the right way to handle this anyways.
If there's ever a working BIOS it will be blacklisted too. And
normally BIOS bugs don't come in one board alone, but in a range
of them and then adding more and more identifiers is quite painful.
Better would be to add some generic sanity checks that catches
the issues these BIOS revisions are having.
> + .callback = blacklist_iommu,
> + .ident = "Intel DG33BU",
> + { DMI_MATCH(DMI_BOARD_VENDOR, "Intel Corporation"),
> + DMI_MATCH(DMI_BOARD_NAME, "DG33BU"),
> + }
> + },
-Andi
--
ak@linux.intel.com
next prev parent reply other threads:[~2008-09-01 22:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-01 20:14 Misc fixes for 2.6.27 David Woodhouse
2008-09-01 22:32 ` Andi Kleen [this message]
2008-09-01 22:35 ` Arjan van de Ven
2008-09-01 23:01 ` Andi Kleen
2008-09-01 23:16 ` Arjan van de Ven
2008-09-02 6:19 ` Andi Kleen
2008-09-02 8:23 ` David Woodhouse
2008-09-03 10:53 ` Blacklist DMAR on Intel G31/G33 chipsets David Woodhouse
2008-09-03 12:09 ` Andi Kleen
2008-09-03 12:22 ` David Woodhouse
2008-09-04 8:54 ` [PATCH] " David Woodhouse
2008-09-05 18:34 ` Ingo Molnar
2008-09-05 18:47 ` David Woodhouse
2008-09-06 15:49 ` Ingo Molnar
2008-09-07 8:20 ` David Woodhouse
2008-09-07 15:35 ` [2.6.27 PATCH] " David Woodhouse
2008-09-09 18:39 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wshvwl8v.fsf@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox