Re: [PATCH] x86: Remove redundant display of free swap space in show_mem()

Johannes Weiner
2008-03-10T18:48:57Z

Hi,

Hugh Dickins <hugh@veritas.com> writes:

> On Mon, 10 Mar 2008, Johannes Weiner wrote:
>> From: Johannes Weiner <hannes@saeurebad.de>
>>
>> show_free_areas() already displays free swap space, no need to do it a
>> second time in show_mem() which calls the former anyway.
>>
>> Signed-off-by: Johannes Weiner <hannes@saeurebad.de>
>
> I heartily approve of this; and yes, it's the per-arch one which should
> go (since its "alignment" looks nasty). But there's a lot more arches
> than just x86 which should be fixed (and so rather more work, preparing
> those patches for the various maintainers) - is that something you'd
> have time to do? (Don't worry, "No" is a perfectly fair answer, and
> it's no way essential that all change at once.)

Yes, I will whip something up. Thanks for the feedback.

Hannes