From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Andrew Morton <akpm@osdl.org>
Cc: Stephen Smalley <sds@epoch.ncsc.mil>,
jmorris@redhat.com, chris@wirex.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Call security hook from pid*_revalidate
Date: Wed, 20 Aug 2003 23:56:14 +0900 [thread overview]
Message-ID: <87wud8pecx.fsf@devron.myhome.or.jp> (raw)
In-Reply-To: <20030819142234.64433bad.akpm@osdl.org>
Andrew Morton <akpm@osdl.org> writes:
> I'm not sure that the /proc/fd ownership patch is the correct solution to
> that bug yet; we'll see.
> dentry->d_inode->i_uid = task->euid;
> dentry->d_inode->i_gid = task->egid;
> + security_task_to_inode(task, dentry->d_inode);
> return 1;
> }
> d_drop(dentry);
> @@ -899,6 +900,7 @@
> put_files_struct(files);
> dentry->d_inode->i_uid = task->euid;
> dentry->d_inode->i_gid = task->egid;
> + security_task_to_inode(task, dentry->d_inode);
> return 1;
> }
> spin_unlock(&files->file_lock);
Umm.. Wasn't the following needed?
inode->i_uid = 0;
inode->i_gid = 0;
if (ino == PROC_PID_INO || task_dumpable(task)) {
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
next prev parent reply other threads:[~2003-08-20 14:57 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-19 8:38 2.6.0-test3-mm3 Andrew Morton
2003-08-19 10:05 ` 2.6.0-test3-mm3 Dumitru Ciobarcianu
2003-08-19 10:17 ` 2.6.0-test3-mm3 Andrew Morton
2003-08-19 10:34 ` [PATCH] 2.6.0-test3-mm3 CaT
2003-08-19 10:09 ` 2.6.0-test3-mm3 Flameeyes
2003-08-19 10:23 ` 2.6.0-test3-mm3 Andrew Morton
2003-08-19 10:34 ` 2.6.0-test3-mm3 Flameeyes
2003-08-19 10:51 ` 2.6.0-test3-mm3 Zwane Mwaikambo
2003-08-19 14:30 ` 2.6.0-test3-mm3 Sam Ravnborg
2003-08-19 13:25 ` 2.6.0-test3-mm3 Luiz Capitulino
2003-08-19 18:32 ` 2.6.0-test3-mm3 Mike Fedyk
2003-08-19 21:10 ` 2.6.0-test3-mm3 Andrew Morton
2003-08-19 21:19 ` [PATCH] Call security hook from pid*_revalidate Stephen Smalley
2003-08-19 21:22 ` Andrew Morton
2003-08-20 14:56 ` OGAWA Hirofumi [this message]
2003-08-21 20:36 ` Stephen Smalley
2003-08-21 21:39 ` Stephen Smalley
2003-08-21 22:18 ` Stephen Smalley
2003-08-22 14:47 ` OGAWA Hirofumi
2003-08-20 0:14 ` 2.6.0-test3-mm3 Diego Calleja García
2003-08-20 3:15 ` 2.6.0-test3-mm3 Jonathan Brown
2003-08-20 3:23 ` 2.6.0-test3-mm3 Andrew Morton
2003-08-21 10:31 ` 2.6.0-test3-mm3 Christian Axelsson
2003-08-20 7:47 ` 2.6.0-test3-mm3 William Lee Irwin III
2003-08-20 9:08 ` 2.6.0-test3-mm3 Gabor MICSKO
2003-08-20 10:54 ` 2.6.0-test3-mm3 Gabor MICSKO
2003-08-20 20:53 ` 2.6.0-test3-mm3 Cliff White
2003-08-22 22:24 ` 2.6.0-test3-mm3 Cliff White
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wud8pecx.fsf@devron.myhome.or.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=akpm@osdl.org \
--cc=chris@wirex.com \
--cc=jmorris@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sds@epoch.ncsc.mil \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox