From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 819BD3DB330; Fri, 10 Jul 2026 09:48:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783676930; cv=none; b=eqlXKc+W7R6U48aWx5QE43p6sY0zyHsRcb4Ehx5O69QT/qC7KXSBkawCJGdO16vqex3v2KOa6mhLnnrhcwhsrTutiaSsh78GEkcB/0icwgyJMPLWmCMin6nqrqhFB2jmI3m/qce4T6BVWGGF089kJ+xInzcgawG/ZsSpHWr3EZ4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783676930; c=relaxed/simple; bh=wuG2shP5X+UkXSmhr4knH5rocVOOk/BakyEWwoAFI/0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=h/Fc8cwg0XpqisHisD4Uoa0SEE+DVd+3Z59Ixun8Jee6jx9L9O0nbzRxn2O2QPhkQ7bemOa+yoF0gAvbvDP6QZT3UsV5dsz+9eSKPyVO9qkd5zQAt8OSZUuThfJ0shkiSiriLE/xKFYra9WE5we+ZuY2aziMJwOXQlii/DRkQpU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=ffO+0698; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="ffO+0698" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id 7E6FFC2F4FE; Fri, 10 Jul 2026 09:49:00 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id ACA1360341; Fri, 10 Jul 2026 09:48:45 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id A21C611BD2834; Fri, 10 Jul 2026 11:48:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1783676924; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=S8k4iLzkxJVSSUQQwc8HGDvZ17LYlFShfGvdGTUVWi8=; b=ffO+0698dM6X34VENvE0Cje5NMC4UCdo5a7VKBYCqDDJFmSorUxab4kQs7JbvzFyYURbcv jTwk1gynEPETItolgJXuY0ZTtmn/jbcpEXq+ip3OLqPaOhyK16EgKQFGQFuquH2uf5F52m J6WZTychwmy5vzMTENDNgSuFjl0pgprv0h1iOM9ZGzElyDo4By8qCmfqGZL/lOW5ZhOBTm TshJisWrE6WbOzwCGGEDbxU9vtLiQ5GW5u/WIkf4RVB5FId3rIdJN7rrxB026RgN1sAavk 3LxOHW3vk1FVgZPcgmmYNap0tUz1NvwrxangAvzwdh/FZZFRTiOKEAYRthfaow== From: Miquel Raynal To: Aleksander Jan Bajkowski Cc: Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thomas Gleixner , Olivia Mackall , Herbert Xu , Jayesh Choudhary , "David S. Miller" , Christian Marangi , Antoine Tenart , Geert Uytterhoeven , Magnus Damm , Thomas Petazzoni , Pascal EBERHARD , Wolfram Sang , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH 02/16] dt-bindings: interrupt-controller: Describe EIP-201 AIC In-Reply-To: <444b4349-3873-4da6-aadd-3605e738ad0d@wp.pl> (Aleksander Jan Bajkowski's message of "Thu, 16 Apr 2026 20:04:03 +0200") References: <20260327-schneider-v7-0-rc1-crypto-v1-0-5e6ff7853994@bootlin.com> <20260327-schneider-v7-0-rc1-crypto-v1-2-5e6ff7853994@bootlin.com> <444b4349-3873-4da6-aadd-3605e738ad0d@wp.pl> User-Agent: mu4e 1.12.7; emacs 30.2 Date: Fri, 10 Jul 2026 11:48:38 +0200 Message-ID: <87y0fjgop5.fsf@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 Hello, >> --- /dev/null >> +++ b/include/dt-bindings/interrupt-controller/inside-secure,safexcel-ei= p201.h >> @@ -0,0 +1,14 @@ >> +/* SPDX-License-Identifier: (GPL-2.0-only OR MIT) */ >> + >> +#ifndef _DT_BINDINGS_IRQ_SAFEXCEL_EIP201_AIC_H >> +#define _DT_BINDINGS_IRQ_SAFEXCEL_EIP201_AIC_H >> + >> +#define AIC_PKA_INT0 0 >> +#define AIC_PKA_INT1 1 >> +#define AIC_PKA_INT2 2 >> +#define AIC_TRNG_INT 3 >> +#define AIC_RESERVED 4 >> +#define AIC_SL_ERR_INT 5 >> +#define AIC_PROTECTION_INT 6 >> + >> +#endif > > This interrupt mapping is specific to the EIP-150. The EIP-201 is also > integrated > into other accelerators, such as the EIP-97, EIP-196, and EIP-197, and the > interrupt mapping is likely different there. Maybe it would be better to = use > eip150 name instead of eip201? I was about to rename the file (and the ifndef/define section), but in the end I feel like it does not actually make sense to do that, because it would require to include one header per container in the driver. Instead, I propose another way: let's keep the file name as-is, but mention with a comment above the definitions that these are specific to the EIP-150 implementation. This way, if someone want to reuse the controller for another integration, they can just add their own interrupt names/numbers below, with another comment stating the name of the container they apply to. For future people who would like to extend this driver to another container: mind that there is currently a list of "unused" interrupts in the v2 of the driver (in the generic chip structure). This list may simply go away if one needs one of the three interrupts currently listed. Thanks, Miqu=C3=A8l