From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 71DAE2459C6; Tue, 24 Mar 2026 14:00:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774360853; cv=none; b=bEnLk0cm0SYr8hJNjnYLTTA4gG4sdTBE06BhBNBOOxXQ7jYgNZeY2fVIDgr8fljMV2vEGZtqqMOwoPvZnFBEG0sEbfOuLMD9wlsasOB5vkRVdTAtIRSLJj5iCdlG0RBTPpwOyeuT8oAMil9+v6Vhm1xVxiAzcggkp5M9l9aWWNE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774360853; c=relaxed/simple; bh=nFDs461qGRQbZs3PvToXFNe9Yue8j0z6IlgIHuLx5a4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=hZBSsDbgk23Awg3mL74Ai2IgRvaBAPj2H6SPUgJZZjUdFQ76Wd/3LGxg6Jvg2jXNZdZQL5bZW0Iv1ooHzgHT0JdrJpn+0cwOAwhiXVRnQ7aFUBgDMSYzLcDRmbboxPHat9Ev5S3dzzlfijXjQ+ZdI6XlerTUekJTQPLuxe1aiQ0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=c+GG5n3k; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="c+GG5n3k" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0E4D8C2BCB2; Tue, 24 Mar 2026 14:00:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774360852; bh=nFDs461qGRQbZs3PvToXFNe9Yue8j0z6IlgIHuLx5a4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=c+GG5n3k/xxHG4snLQ1EG5kug4Nq1Cmfjoz9ogNaXvCvfIBd5iAXGuxp7qggPkxj5 AqyiHCNzem3YnkLqqsZnt7zkALfB6K2GMfiUcLDTGcHwva7ASJNqg8F1ZEWiVEDfb1 yDzgBpJmUTp3QhkPZQxPHMdrSJFRZFmvkVv1kgtETcfKmPxRoCO3mY3gNoG8HL70pY UCgOUeIq4JlysINNVPNLQUHHFge1cemwUbsPNMM4TxE1rNcCmREQbR24j6dX/Cs10s ywV8Hgqr3S5Av0TBfFEsZ5Ys+WeCNz33hZkE+S9bx3Z/0bh//ZcGpKuinGq1qTRvBV GAKXlR2CxyDHQ== From: Andreas Hindborg To: Danilo Krummrich , aliceryhl@google.com, acourbot@nvidia.com, ojeda@kernel.org, boqun@kernel.org, gary@garyguo.net, bjorn3_gh@protonmail.com, lossin@kernel.org, tmgross@umich.edu, abdiel.janulgue@gmail.com, daniel.almeida@collabora.com, robin.murphy@arm.com Cc: driver-core@lists.linux.dev, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, Danilo Krummrich Subject: Re: [PATCH v2 5/8] rust: dma: add Coherent:init() and Coherent::init_with_attrs() In-Reply-To: <20260320194626.36263-6-dakr@kernel.org> References: <20260320194626.36263-1-dakr@kernel.org> <4yknLBbwY93Ty2ltbpxjHgto-m99xkoTgDlKv8cJTK2tbFL0_V6eQDjwbbXI70M6uMKT6RLRxBoYR_XeymmnHA==@protonmail.internalid> <20260320194626.36263-6-dakr@kernel.org> Date: Tue, 24 Mar 2026 15:00:38 +0100 Message-ID: <87y0jhpbsp.fsf@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain "Danilo Krummrich" writes: > Analogous to Coherent::zeroed() and Coherent::zeroed_with_attrs(), add > Coherent:init() and Coherent::init_with_attrs() which both take an impl > Init argument initializing the DMA coherent memory. > > Compared to CoherentInit, Coherent::init() is a one-shot constructor > that runs an Init closure and immediately exposes the DMA handle, > whereas CoherentInit is a multi-stage initializer that provides safe > &mut T access by withholding the DMA address until converted to > Coherent. You forgot to update this to CoherentBox > > Signed-off-by: Danilo Krummrich > --- > rust/kernel/dma.rs | 38 ++++++++++++++++++++++++++++++++++++++ > 1 file changed, 38 insertions(+) > > diff --git a/rust/kernel/dma.rs b/rust/kernel/dma.rs > index cefb54f0424a..6d2bec52806b 100644 > --- a/rust/kernel/dma.rs > +++ b/rust/kernel/dma.rs > @@ -709,6 +709,44 @@ pub fn zeroed(dev: &device::Device, gfp_flags: kernel::alloc::Flags) -> R > Self::zeroed_with_attrs(dev, gfp_flags, Attrs(0)) > } > > + /// Same as [`Coherent::zeroed_with_attrs`], but instead of a zero-initialization the memory is > + /// initialized with `init`. > + pub fn init_with_attrs( > + dev: &device::Device, > + gfp_flags: kernel::alloc::Flags, > + dma_attrs: Attrs, > + init: impl Init, > + ) -> Result > + where > + Error: From, > + { > + let dmem = Self::alloc_with_attrs(dev, gfp_flags, dma_attrs)?; > + let ptr = dmem.as_mut_ptr(); > + > + // SAFETY: > + // - `ptr` is valid, properly aligned, and points to exclusively owned memory. > + // - If `__init` fails, `self` is dropped, which safely frees the underlying `Coherent`'s > + // DMA memory. `T: AsBytes + FromBytes` ensures there are no complex `Drop` requirements > + // we are bypassing. > + unsafe { init.__init(ptr)? }; > + > + Ok(dmem) > + } > + > + /// Same as [`Coherent::zeroed`], but instead of a zero-initialization the memory is initialized > + /// with `init`. > + #[inline] > + pub fn init( > + dev: &device::Device, > + gfp_flags: kernel::alloc::Flags, > + init: impl Init, > + ) -> Result > + where > + Error: From, > + { > + Self::init_with_attrs(dev, gfp_flags, Attrs(0), init) > + } > + I think we are missing an array initializer for `Coherent<[T]>`. Reviewed-by: Andreas Hindborg Best regards, Andreas Hindborg