From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 659A02FE582
	for <linux-kernel@vger.kernel.org>; Mon, 23 Mar 2026 21:27:40 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1774301260; cv=none; b=WIExbIELmiTwuGlBu05wG/8uZ3TY7xMTGORhYqwEHdIUDBqHfnydONqfqTWk+OYbzTwWibAp1kCCQ6kMrxeJUum8EW/OILzCfh3BWuMdldB3nrUf0/61DGlxL0XwHKbVbc6gINUjcMcMI5fALkeqG5mcKaokdECHS7LlZ3x8CTM=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1774301260; c=relaxed/simple;
	bh=19w+UUMHkld55WfWAGElyg2mYe72YfjxQyOgfL57Ndc=;
	h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID:
	 MIME-Version:Content-Type; b=QYzozddYAsOhkj7U1JqWGTCTS9D3B8LU6QjkM1Y73QQUM64j66qDc5iOog91pZKRFsp0uvYUlxB20xj8PCIy/svCoJskBv64xVo+3vqsIt3itM7j2EOdbYQ4kKvTNISSTsHkITPjfdIk1YYT4rVTRGH6y78sDFWWBRUmrHZHh8E=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=EVFaRNHU; arc=none smtp.client-ip=10.30.226.201
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="EVFaRNHU"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id E2EE1C4CEF7;
	Mon, 23 Mar 2026 21:27:38 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1774301259;
	bh=19w+UUMHkld55WfWAGElyg2mYe72YfjxQyOgfL57Ndc=;
	h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
	b=EVFaRNHUq+3SorvPaJzvrXVg7FISrQP/cGhcxYZ08JcWaJt7j+lsNa5GL19Zw1qtO
	 apyDlWu6/KLNV6sIVPLH8LbUpBqlA9OjI6KKb3h33dgq0JSLvpjTSO7lxj4x+JKzlP
	 T72b+yMEKiSsTHHvOkyn9hqjWA6NAIFMMrYzRmkefq/4ZtdEjlQs11vSdtiYgniSZQ
	 XAdFyg0117Y2m5QiZkQVtWmLhp2rrjr6xeVzvJekJ/bTbwOdgRf8HjTrAsdxt4dOUV
	 PT7AwbmQcgzwUf4j+IgyhGaPGrNUdy8ZX9mWAM7MeRQxzwKkoXn25v7tDyix9HwXVI
	 yBo/3gNgG+OSA==
From: Thomas Gleixner <tglx@kernel.org>
To: Radu Rendec <radu@rendec.net>, LKML <linux-kernel@vger.kernel.org>
Cc: x86@kernel.org, Dmitry Ilvokhin <d@ilvokhin.com>, Neil Horman
 <nhorman@tuxdriver.com>
Subject: Re: [patch v2 05/14] genirq: Expose nr_irqs in core code
In-Reply-To: <4826b7249e4276677fa4bee4100b72d1ef0f98fd.camel@rendec.net>
References: <20260320131108.344376329@kernel.org>
 <20260320132102.364535811@kernel.org>
 <4826b7249e4276677fa4bee4100b72d1ef0f98fd.camel@rendec.net>
Date: Mon, 23 Mar 2026 22:27:35 +0100
Message-ID: <87y0jigrso.ffs@tglx>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On Mon, Mar 23 2026 at 15:48, Radu Rendec wrote:
> On Fri, 2026-03-20 at 14:21 +0100, Thomas Gleixner wrote:
>> =C2=A0#ifndef ACTUAL_NR_IRQS
>> -# define ACTUAL_NR_IRQS irq_get_nr_irqs()
>> +# define ACTUAL_NR_IRQS total_nr_irqs
>> =C2=A0#endif
>> =C2=A0
>> =C2=A0#define ZSTR1 "=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0 0"
>
> Nit: This is modified again in the next patch, so it doesn't matter.
> But for the purpose of this patch in isolation, looking at where
> ACTUAL_NR_IRQS is used, in show_interrupts() the nr_irqs variable
> should also be initialized to total_nr_irqs to avoid the extra function
> call.

Indeed.