From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.parknet.co.jp (mail.parknet.co.jp [210.171.160.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BB8E33066E for ; Wed, 4 Feb 2026 05:29:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=210.171.160.6 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770182966; cv=none; b=QMM1I4jCehkMxM8HGE4nfFLEay3rMWre+vzaWf2/6T6OeB0BSKJn+bgaNax5YJR8agZFzb/gjJu/XZGqVJpgW/+iyfJagC8DS7vgO6bR70+FCGP9jLh09n/zTXHfS8ILOOQwbIfskysqhYleKxLngKHWTBFMXire3EVdo4V7PLc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770182966; c=relaxed/simple; bh=EN4wNmt1YAud5pSE5k3GKwgA/ujSvzWQAlphQzQAaaQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=Mg1EUiQsY6NtawKzsZXjrRa6jB11Kb7Y8ej06sDQrZo4ikrZ9R5kyT6ffK/yaKMQVlTjDdy4P4TILJawmcqKjF0VIHKEgpoyErJkrc/94iqoEb38F7igTgGtiIpgot5yYW2ai5HO1Zlq8QSFgeYQXyKSbuIcaBa+WkZMPQbCz2o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mail.parknet.co.jp; spf=pass smtp.mailfrom=parknet.co.jp; dkim=pass (2048-bit key) header.d=parknet.co.jp header.i=@parknet.co.jp header.b=oG4FxZfC; dkim=permerror (0-bit key) header.d=parknet.co.jp header.i=@parknet.co.jp header.b=Y8ZJmqp5; arc=none smtp.client-ip=210.171.160.6 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mail.parknet.co.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=parknet.co.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=parknet.co.jp header.i=@parknet.co.jp header.b="oG4FxZfC"; dkim=permerror (0-bit key) header.d=parknet.co.jp header.i=@parknet.co.jp header.b="Y8ZJmqp5" Received: from ibmpc.myhome.or.jp (server.parknet.ne.jp [210.171.168.39]) by mail.parknet.co.jp (Postfix) with ESMTPSA id D6C01209655A; Wed, 4 Feb 2026 14:20:59 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=parknet.co.jp; s=20250114; t=1770182460; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8cOqFkkNSJ8wVuKxBGamnj0OkRhK0fZ06B3g5qr3CWY=; b=oG4FxZfC7iwVM9cYkYqThg+Fkvq0iFscNyY2LdirYZ3xylrpsr+7Ji3Lk2WuhGYlS46Rnj jQzoOfGRE1ypWiMqh/lDpeNTB7XT6zR9bGxuKjpJ2HEv+njB2ENl2b4uiir+GaYKbUso0D UufBgp+UX9wBN/bzOmZ5RTPSG5MxHH3SgTs6k4eg3XMiGC8WDejs1oJOmUx79N+ZVM/jbR QzAZ1NpFDw1V9i1r/wQFa+GmAu+/Kmpb8cZW8xoT5g/GcPs4xeJtOXFMBKakAEulPdqPA9 kfAOYIhUesb+tQNx+nE3PDGCKBpCwEgNJCf/N0y5rzDAKRYqyVOIzV0il+TBbw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=parknet.co.jp; s=20250114-ed25519; t=1770182460; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8cOqFkkNSJ8wVuKxBGamnj0OkRhK0fZ06B3g5qr3CWY=; b=Y8ZJmqp5JsG8IaiPY4F2iRu1h2ePAZXuZ2Cej/vYx4WD0zP8tiocTIQGZExxQ+gi5qpY89 85Oxhz6MZjz9f9CQ== Received: from devron.myhome.or.jp (foobar@devron.myhome.or.jp [192.168.0.3]) by ibmpc.myhome.or.jp (8.18.2/8.18.2/Debian-1) with ESMTPS id 6145KwB8205849 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 4 Feb 2026 14:20:59 +0900 Received: from devron.myhome.or.jp (foobar@localhost [127.0.0.1]) by devron.myhome.or.jp (8.18.2/8.18.2/Debian-1) with ESMTPS id 6145KwYM691163 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 4 Feb 2026 14:20:58 +0900 Received: (from hirofumi@localhost) by devron.myhome.or.jp (8.18.2/8.18.2/Submit) id 6145Kvh7691162; Wed, 4 Feb 2026 14:20:57 +0900 From: OGAWA Hirofumi To: George Hu Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] fat: remove unused fat_tolower() and use to_lower() instead In-Reply-To: <20260204035940.133747-1-integral@archlinux.org> References: <20260204035940.133747-1-integral@archlinux.org> Date: Wed, 04 Feb 2026 14:20:57 +0900 Message-ID: <87y0l9t77q.fsf@mail.parknet.co.jp> User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain George Hu writes: > The fat_tolower() function is redundant, as it is functionally > equivalent to the to_lower() macro defined in include/linux/ctype.h. No, it is not equivalent. Thanks. > Signed-off-by: George Hu > --- > fs/fat/dir.c | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a/fs/fat/dir.c b/fs/fat/dir.c > index 92b091783966..4f46d2358185 100644 > --- a/fs/fat/dir.c > +++ b/fs/fat/dir.c > @@ -18,6 +18,7 @@ > #include > #include > #include > +#include > #include "fat.h" > > /* > @@ -33,11 +34,6 @@ > #define FAT_MAX_UNI_CHARS ((MSDOS_SLOTS - 1) * 13 + 1) > #define FAT_MAX_UNI_SIZE (FAT_MAX_UNI_CHARS * sizeof(wchar_t)) > > -static inline unsigned char fat_tolower(unsigned char c) > -{ > - return ((c >= 'A') && (c <= 'Z')) ? c+32 : c; > -} > - > static inline loff_t fat_make_i_pos(struct super_block *sb, > struct buffer_head *bh, > struct msdos_dir_entry *de) > @@ -396,7 +392,7 @@ static int fat_parse_short(struct super_block *sb, > de->lcase & CASE_LOWER_BASE); > if (chl <= 1) { > if (!isvfat) > - ptname[i] = nocase ? c : fat_tolower(c); > + ptname[i] = nocase ? c : tolower(c); > i++; > if (c != ' ') { > name_len = i; > @@ -433,7 +429,7 @@ static int fat_parse_short(struct super_block *sb, > if (chl <= 1) { > k++; > if (!isvfat) > - ptname[i] = nocase ? c : fat_tolower(c); > + ptname[i] = nocase ? c : tolower(c); > i++; > if (c != ' ') { > name_len = i; -- OGAWA Hirofumi