public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Martin Hamilton <m@martinh.net>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda/realtek: ALC269 fixup for Lenovo Yoga Book 9i 13IRU8 audio
Date: Thu, 22 Jan 2026 13:34:49 +0100	[thread overview]
Message-ID: <87y0lphlli.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260122-alc269-yogabook9i-fixup-v1-1-a6883429400f@martinh.net>

On Thu, 22 Jan 2026 03:51:18 +0100,
Martin Hamilton wrote:
> 
> 
> 
> ---

Please drop this delimiter at the next time; otherwise all texts below
would be dropped at applying the patch.

> The amp/speakers on the Lenovo Yoga Book 9i 13IRU8 laptop aren't
> fully powered up, resulting in horrible tinny sound by default.
> 
> The kernel has an existing quirk for PCI SSID 0x17aa3843 which
> matches this machine and several others. The quirk applies the
> ALC287_FIXUP_IDEAPAD_BASS_SPK_AMP fixup, however the fixup does not
> work on this machine.
> 
> This patch modifies the existing quirk by adding a check for the
> subsystem ID 0x17aa3881. If present, ALC287_FIXUP_TAS2781_I2C will
> be applied instead of ALC287_FIXUP_IDEAPAD_BASS_SPK_AMP. With this
> change the TAS2781 amp is powered up, firmware is downloaded and
> recognised by HDA/SOF - i.e. all is good, and we can boogie.
> 
> Code is re-used from alc298_fixup_lenovo_c940_duet7(), which fixes a
> similar problem with two other Lenovo laptops.
> 
> Cross checked against ALSA cardinfo database for potential clashes.
> Tested against 6.18.5 kernel built with Arch Linux default options.
> Tested in HDA mode and SOF mode.
> 
> Note: Possible further work required to address quality of life issues
> caused by the firmware's agressive power saving, and to improve ALSA
> control mappings.
> 
> Signed-off-by: Martin Hamilton <m@martinh.net>

Applied now.  Thanks.


Takashi

      reply	other threads:[~2026-01-22 12:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-22  2:51 [PATCH] ALSA: hda/realtek: ALC269 fixup for Lenovo Yoga Book 9i 13IRU8 audio Martin Hamilton
2026-01-22 12:34 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y0lphlli.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=m@martinh.net \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox