From: Thomas Gleixner <tglx@kernel.org>
To: Imran Khan <imran.f.khan@oracle.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v2] genirq/cpuhotpug: notify of irq affinity change for offlined cpu.
Date: Tue, 13 Jan 2026 10:24:59 +0100 [thread overview]
Message-ID: <87y0m1eufo.ffs@tglx> (raw)
In-Reply-To: <871pjtg91b.ffs@tglx>
On Tue, Jan 13 2026 at 10:24, Thomas Gleixner wrote:
> On Sat, Jan 03 2026 at 00:53, Imran Khan wrote:
>> + if (affinity_broken && desc->affinity_notify) {
>> + kref_get(&desc->affinity_notify->kref);
>> + if (!schedule_work(&desc->affinity_notify->work)) {
>> + /* Work was already scheduled, drop our extra ref */
>> + kref_put(&desc->affinity_notify->kref,
>> + desc->affinity_notify->release);
>> + }
>> + }
>
> No, we are not doing random copy&pasta.
>
> Split out the functionality into a function and use it both here and in
> irq_set_affinity_locked().
And while at it you might fix the typos in subject and change log.
next prev parent reply other threads:[~2026-01-13 9:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-02 16:53 [RFC PATCH v2] genirq/cpuhotpug: notify of irq affinity change for offlined cpu Imran Khan
2026-01-13 9:24 ` Thomas Gleixner
2026-01-13 9:24 ` Thomas Gleixner [this message]
2026-01-13 14:41 ` imran.f.khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y0m1eufo.ffs@tglx \
--to=tglx@kernel.org \
--cc=imran.f.khan@oracle.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox