public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Alexey Charkov <alchark@gmail.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
	 Rob Herring <robh@kernel.org>, Mark Brown <broonie@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	 Tudor Ambarus <tudor.ambarus@linaro.org>,
	 Pratyush Yadav <pratyush@kernel.org>,
	Michael Walle <mwalle@kernel.org>,
	 Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	 linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
	 linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
	 linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] dt-bindings: spi: Add VIA/WonderMedia serial flash controller
Date: Mon, 09 Jun 2025 11:07:27 +0200	[thread overview]
Message-ID: <87y0u1z3jk.fsf@bootlin.com> (raw)
In-Reply-To: <CABjd4YxRMfi3ZFQxhB__6U4Rm3KQ7bm6J=wQLWAkpb++61ddEg@mail.gmail.com> (Alexey Charkov's message of "Fri, 6 Jun 2025 13:06:22 +0400")

Hi Alexey,

>> > Happy to reference the spi-controller.yaml binding if so.
>>
>> SPI NOR flashes are still child devices of an SPI controller. You can
>> look at other examples - aren't they all using spi-controller? Why this
>> would be different? Unless you found some cases that are different, but
>> then which ones?
>
> No strong opinions here, and no expectation of any special treatment
> :) Just wanted to consult on what's most appropriate.
>
> My (subjective and perhaps unfounded) expectation when seeing
> something advertise itself as an SPI controller was that it would be a
> general purpose SPI master, to which one can e.g. connect an SPI
> driven LCD screen and get it to work with generic Linux SPI
> infrastructure - which would not be possible with this single-purpose
> NOR-only flash controller. Given that I don't know how flexible or
> restrictive other examples are in terms of driving arbitrary SPI
> devices, I thought it's better to just ask.
>
> What I'm getting from this exchange here is that I'd better use the
> spi-controller binding and respective node names regardless of the
> fact that this controller cannot drive arbitrary SPI devices beyond
> NOR flash (which, as I'm getting, is irrelevant after all).

Just for information, there are several SPI controllers which are
optimized for flash handling (not only NOR, though) and for that we have
a spi-mem layer which allows to reference a set of SPI memory "only"
callbacks. On the description side though, these controllers are like
all other SPI controllers, so the same controller bindings may apply.

Thanks,
Miquèl

  reply	other threads:[~2025-06-09  9:07 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-10 19:42 [PATCH 0/3] mtd: spi-nor: Add VIA/WonderMedia serial flash controller driver Alexey Charkov
2025-05-10 19:42 ` [PATCH 1/3] dt-bindings: spi: Add VIA/WonderMedia serial flash controller Alexey Charkov
2025-05-14 20:41   ` Rob Herring
2025-05-15 19:50     ` Alexey Charkov
2025-06-06  8:29       ` Krzysztof Kozlowski
2025-06-06  9:06         ` Alexey Charkov
2025-06-09  9:07           ` Miquel Raynal [this message]
2025-06-09  9:15             ` Alexey Charkov
2025-05-10 19:42 ` [PATCH 2/3] mtd: spi-nor: Add a driver for the " Alexey Charkov
2025-05-11 11:13   ` kernel test robot
2025-05-11 12:16   ` kernel test robot
2025-05-12  9:20   ` Pratyush Yadav
2025-05-12 17:50     ` Alexey Charkov
2025-07-24 13:51       ` Pratyush Yadav
2025-07-28  7:09         ` Mika Westerberg
2025-05-10 19:42 ` [PATCH 3/3] ARM: dts: vt8500: Add serial flash controller and its clock Alexey Charkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y0u1z3jk.fsf@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=alchark@gmail.com \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=mwalle@kernel.org \
    --cc=pratyush@kernel.org \
    --cc=richard@nod.at \
    --cc=robh@kernel.org \
    --cc=tudor.ambarus@linaro.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox