public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: "Roger Pau Monné" <roger.pau@citrix.com>,
	"Daniel Gomez" <da.gomez@kernel.org>
Cc: "Jürgen Groß" <jgross@suse.com>,
	"Bjorn Helgaas" <helgaas@kernel.org>,
	linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org,
	linux-pci@vger.kernel.org, "Bjorn Helgaas" <bhelgaas@google.com>,
	"Ingo Molnar" <mingo@redhat.com>,
	"Borislav Petkov" <bp@alien8.de>,
	"Dave Hansen" <dave.hansen@linux.intel.com>,
	x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH v3 3/3] PCI/MSI: Convert pci_msi_ignore_mask to per MSI domain flag
Date: Tue, 25 Mar 2025 09:11:08 +0100	[thread overview]
Message-ID: <87y0wtzg0z.ffs@tglx> (raw)
In-Reply-To: <Z-Gv6TG9dwKI-fvz@macbook.local>

On Mon, Mar 24 2025 at 20:18, Roger Pau Monné wrote:
> On Mon, Mar 24, 2025 at 07:58:14PM +0100, Daniel Gomez wrote:
>> The issue is that info appears to be uninitialized. So, this worked for me:
>
> Indeed, irq_domain->host_data is NULL, there's no msi_domain_info.  As
> this is x86, I was expecting x86 ot always use
> x86_init_dev_msi_info(), but that doesn't seem to be the case.  I
> would like to better understand this.

Indeed. On x86 this should not happen at all. On architectures, which do
not use (hierarchical) interrupt domains, it will return NULL.

So I really want to understand why this happens on x86 before such a
"fix" is deployed.

Thanks,

        tglx

  parent reply	other threads:[~2025-03-25  8:11 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-19  9:20 [PATCH v3 0/3] xen: Fix usage of devices behind a VMD bridge Roger Pau Monne
2025-02-19  9:20 ` [PATCH v3 1/3] xen/pci: Do not register devices with segments >= 0x10000 Roger Pau Monne
2025-02-19  9:20 ` [PATCH v3 2/3] PCI: vmd: Disable MSI remapping bypass under Xen Roger Pau Monne
2025-03-03 14:16   ` Roger Pau Monné
2025-03-20 21:06   ` Bjorn Helgaas
2025-02-19  9:20 ` [PATCH v3 3/3] PCI/MSI: Convert pci_msi_ignore_mask to per MSI domain flag Roger Pau Monne
2025-03-20 21:07   ` Bjorn Helgaas
2025-03-21  8:00     ` Jürgen Groß
2025-03-24 14:29       ` Daniel Gomez
2025-03-24 17:51         ` Roger Pau Monné
2025-03-24 18:58           ` Daniel Gomez
2025-03-24 19:18             ` Roger Pau Monné
2025-03-24 20:45               ` Daniel Gomez
2025-03-25  8:11               ` Thomas Gleixner [this message]
2025-03-25  9:20                 ` Thomas Gleixner
2025-03-25  9:47                   ` Daniel Gomez
2025-03-25 10:22                   ` Roger Pau Monné
2025-03-25 10:27                     ` Thomas Gleixner
2025-03-25 10:55                       ` Roger Pau Monné
2025-03-26  8:14                         ` Thomas Gleixner
2025-03-26  8:10                   ` Roger Pau Monné
2025-03-26 11:26                   ` Marek Szyprowski
2025-03-26 12:05                   ` [PATCH] PCI/MSI: Handle the NOMASK flag correctly for all PCI/MSI backends Thomas Gleixner
2025-03-26 12:09                     ` Jürgen Groß
2025-03-26 12:46                       ` Thomas Gleixner
2025-03-26 12:16                     ` Juergen Gross
2025-03-26 14:39                     ` [tip: timers/urgent] " tip-bot2 for Thomas Gleixner
2025-03-30 14:57                   ` [PATCH] " Bert Karwatzki
2025-03-26 11:04   ` [PATCH v3 3/3] PCI/MSI: Convert pci_msi_ignore_mask to per MSI domain flag Borislav Petkov
2025-03-26 11:14     ` Roger Pau Monné
2025-03-26 11:21       ` Borislav Petkov
2025-03-06  8:48 ` [PATCH v3 0/3] xen: Fix usage of devices behind a VMD bridge Roger Pau Monné
2025-03-20 16:21   ` Roger Pau Monné

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y0wtzg0z.ffs@tglx \
    --to=tglx@linutronix.de \
    --cc=bhelgaas@google.com \
    --cc=bp@alien8.de \
    --cc=da.gomez@kernel.org \
    --cc=dave.hansen@linux.intel.com \
    --cc=helgaas@kernel.org \
    --cc=hpa@zytor.com \
    --cc=jgross@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=roger.pau@citrix.com \
    --cc=x86@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox