From: Thomas Gleixner <tglx@linutronix.de>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-kernel@vger.kernel.org
Cc: linux-tip-commits@vger.kernel.org, x86@kernel.org
Subject: Re: [tip: timers/urgent] hrtimers: Mark is_migration_base() with __always_inline
Date: Thu, 23 Jan 2025 20:02:37 +0100 [thread overview]
Message-ID: <87y0z18ib6.ffs@tglx> (raw)
In-Reply-To: <Z5JUoM70IVkkxo3i@smile.fi.intel.com>
On Thu, Jan 23 2025 at 16:39, Andy Shevchenko wrote:
> On Thu, Jan 23, 2025 at 10:57:32AM -0000, tip-bot2 for Andy Shevchenko wrote:
>> The following commit has been merged into the timers/urgent branch of tip:
>>
>> Commit-ID: 3ff6e36be060f0a8870f76155e14de128058b964
>> Gitweb: https://git.kernel.org/tip/3ff6e36be060f0a8870f76155e14de128058b964
>> Author: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>> AuthorDate: Thu, 16 Jan 2025 18:07:45 +02:00
>> Committer: Thomas Gleixner <tglx@linutronix.de>
>> CommitterDate: Thu, 23 Jan 2025 11:47:23 +01:00
>>
>> hrtimers: Mark is_migration_base() with __always_inline
>>
>> When is_migration_base() is unused, it prevents kernel builds
>> with clang, `make W=1` and CONFIG_WERROR=y:
>>
>> kernel/time/hrtimer.c:156:20: error: unused function 'is_migration_base' [-Werror,-Wunused-function]
>> 156 | static inline bool is_migration_base(struct hrtimer_clock_base *base)
>> | ^~~~~~~~~~~~~~~~~
>>
>> Fix this by marking it with __always_inline.
>
>> [ tglx: Use __always_inline instead of __maybe_unused ]
>
> Thanks, but it doesn't fix the problem:
>
> kernel/time/hrtimer.c:156:29: error: unused function 'is_migration_base' [-Werror,-Wunused-function]
> 156 | static __always_inline bool is_migration_base(struct hrtimer_clock_base *base)
> | ^~~~~~~~~~~~~~~~~
> 1 error generated.
This is insane. Let me undo that for heavens sake.
next prev parent reply other threads:[~2025-01-23 19:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-16 16:07 [PATCH v1 1/1] hrtimer: Mark is_migration_base() with __maybe_unused Andy Shevchenko
2025-01-23 10:57 ` [tip: timers/urgent] hrtimers: Mark is_migration_base() with __always_inline tip-bot2 for Andy Shevchenko
2025-01-23 14:39 ` Andy Shevchenko
2025-01-23 19:02 ` Thomas Gleixner [this message]
2025-01-23 19:13 ` tip-bot2 for Andy Shevchenko
2025-01-23 20:22 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y0z18ib6.ffs@tglx \
--to=tglx@linutronix.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox