From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80B0D15359A for ; Fri, 1 Nov 2024 11:46:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730461605; cv=none; b=Asd39/yux0EMMzd5yJHvKs9LPJqrwiPjBwNN4IVtGXVsDoHrFQQEloLHT1lDSRo/scyZav0oJTTX8r/aFFnOaYdcBimnxUJ6XL16zdrdGgiSIMAO24n7b7diiNyYjDeN8kaPFn9ccwsfdn1NZkMMR45kKzzGW8B3u75q+P/sYms= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730461605; c=relaxed/simple; bh=Ao7+jhiwR7VMIsjhTd++zXohFMFnpGuaBIUcGCft5Cc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=APXJ3xZ0HqTTUENOCwrVXFNKxf+Jb8WHqV8sn2p7gX9EmcyRmI1EmjHydcImziqurZCQVB3tWazdmPdnIqpa5tXK7H4pNF9cmQkaVLMSY3L1tCuahWRa0X+RHV+ogyc9AVcnI3MWsSHkCvg9yFK14bSpKnl8ji50Jmv4DaM6DP0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=QWyn/klj; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QWyn/klj" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730461601; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ao7+jhiwR7VMIsjhTd++zXohFMFnpGuaBIUcGCft5Cc=; b=QWyn/kljIP3JnXLIqW8bvXc0L5vud+QW7vYu7Y5fCF25xLc7kuGJZbAI92thJFAjbDobts OPB4VGg5ZuZp81zPSY2gHFOJ8rD1QKlm3oP5UjNVhCgAZZQjDqfHwuAVd0nn0s9VNT8xrB m1E79o2s3UR+MpiISIdB3xmvz0AN0D0= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-275-DcnFqWBfMsK1woMaL7OklA-1; Fri, 01 Nov 2024 07:46:40 -0400 X-MC-Unique: DcnFqWBfMsK1woMaL7OklA-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-431604a3b47so11650475e9.3 for ; Fri, 01 Nov 2024 04:46:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730461599; x=1731066399; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ao7+jhiwR7VMIsjhTd++zXohFMFnpGuaBIUcGCft5Cc=; b=M9iOLuL5xwFa1NCKxKMdaqX7RXwOdZzIrpOodNZKDhRbP8S6LITyNvNfLS2FUzExSC VeaBKiSLkfBe6kjoJ9nCcZYDmnevSLYXBZt0+oJ9Bgp5C7qnpqrahFpURV5xx9J37qxE LA6zdoaQauFCzCr5Lr8s3/eeSXMiaXGZ7o1UFxjw2M5U1+p/mj1bZdWpEOXC4q9QYjNg 50Ckd182jZLAEbzJa54jcntzoGAuP1Igkjcoj/O5EVoenEK52BELbNu2qo8eX09pZQgo dZ62Cwk1EM8nEy1V6tw/N8P+G099SEni4cYxNAX7AAQIriTeeEG7DU6jcPwpCKSy06dW EMOA== X-Forwarded-Encrypted: i=1; AJvYcCVkyZavUQRGEo98SQbUQ/+EecjcAwMcPvj8d/0rRwVjDbUOLnEtmVvHc1W4E/+Zh6zo0Kxda3nOPtDMU9E=@vger.kernel.org X-Gm-Message-State: AOJu0YxAZ9dLMRUpNrZXgmrpmkAKnRhWj7an+5t4o3L84vocXZ9+gwTo x/GQLApuKJJtuZ/L+7DtFgn07bWphK4N9WlEcFExOnbEsb2DgqmT9zVaeZ4vW5tvV7qJOB1UhW4 3FGpD6SLasxD1H/RZcHtisaBXL4PBod4wF0dAXxF7WCl8P8k3bKTp5ttTpNUUnQ== X-Received: by 2002:a05:600c:1548:b0:42f:80f4:ab31 with SMTP id 5b1f17b1804b1-4319acadc1emr190571875e9.18.1730461599298; Fri, 01 Nov 2024 04:46:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHpDaFcEn6EWvQmh/U5bQPmg4IvB1Z9BcupW5ULubk3inI7A9bmwOF6H9T18cXj699H1zpfAQ== X-Received: by 2002:a05:600c:1548:b0:42f:80f4:ab31 with SMTP id 5b1f17b1804b1-4319acadc1emr190571655e9.18.1730461598850; Fri, 01 Nov 2024 04:46:38 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk ([45.145.92.2]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-431bd8e853esm90363425e9.8.2024.11.01.04.46.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Nov 2024 04:46:37 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id CE513164B94C; Fri, 01 Nov 2024 12:46:36 +0100 (CET) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Alexander Lobakin , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Alexander Lobakin , Alexei Starovoitov , Daniel Borkmann , John Fastabend , Andrii Nakryiko , Maciej Fijalkowski , Stanislav Fomichev , Magnus Karlsson , nex.sw.ncis.osdt.itp.upstreaming@intel.com, bpf@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v3 04/18] bpf, xdp: constify some bpf_prog * function arguments In-Reply-To: <20241030165201.442301-5-aleksander.lobakin@intel.com> References: <20241030165201.442301-1-aleksander.lobakin@intel.com> <20241030165201.442301-5-aleksander.lobakin@intel.com> X-Clacks-Overhead: GNU Terry Pratchett Date: Fri, 01 Nov 2024 12:46:36 +0100 Message-ID: <87y1239nxf.fsf@toke.dk> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Alexander Lobakin writes: > In lots of places, bpf_prog pointer is used only for tracing or other > stuff that doesn't modify the structure itself. Same for net_device. > Address at least some of them and add `const` attributes there. The > object code didn't change, but that may prevent unwanted data > modifications and also allow more helpers to have const arguments. > > Signed-off-by: Alexander Lobakin Reviewed-by: Toke H=C3=B8iland-J=C3=B8rgensen