Re: [PATCH 00/15] timers: Cleanup delay/sleep related mess

Rafael J. Wysocki
2024-09-04T14:45:00Z

On Wed, Sep 4, 2024 at 3:05 PM Anna-Maria Behnsen
<anna-maria@linutronix.de> wrote:
>
> Hi,
>
> a question about which sleeping function should be used in acpi_os_sleep()
> started a discussion and examination about the existing documentation and
> implementation of functions which insert a sleep/delay.
>
> The result of the discussion was, that the documentation is outdated and
> the implemented fsleep() reflects the outdated documentation but doesn't
> help to reflect reality which in turns leads to the queue which covers the
> following things:
>
> - Minor changes (naming and typo fixes)
>
> - Split out all timeout and sleep related functions from hrtimer.c and timer.c
> into a separate file
>
> - Update function descriptions of sleep related functions
>
> - Change fsleep() to reflect reality
>
> - Rework all comments or users which obviously rely on the outdated
> documentation as they reference "Documentation/timers/timers-howto.rst"
>
> - Last but not least (as there are no more references): Update the outdated
> documentation and move it into a file with a self explaining file name
>
> The queue is available here and applies on top of tip/timers/core:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/anna-maria/linux-devel.git timers/misc
>
> Cc: linux-kernel@vger.kernel.org
> Cc: Len Brown <len.brown@intel.com>
> Cc: Rafael J. Wysocki <rafael@kernel.org>
> To: Frederic Weisbecker <frederic@kernel.org>
> To: Thomas Gleixner <tglx@linutronix.de>
> To: Jonathan Corbet <corbet@lwn.net>
> Signed-off-by: Anna-Maria Behnsen <anna-maria@linutronix.de>
>
> Thanks,
>
> Anna-Maria
>
> ---
> Anna-Maria Behnsen (15):
> timers: Rename next_expiry_recalc() to be unique
> cpu: Use already existing usleep_range()
> Comments: Fix wrong singular form of jiffies
> timers: Move *sleep*() and timeout functions into a separate file
> timers: Rename sleep_idle_range() to sleep_range_idle()
> timers: Update function descriptions of sleep/delay related functions
> timers: Adjust flseep() to reflect reality
> mm/damon/core: Use generic upper bound recommondation for usleep_range()
> timers: Add a warning to usleep_range_state() for wrong order of arguments
> checkpatch: Remove broken sleep/delay related checks
> regulator: core: Use fsleep() to get best sleep mechanism
> iopoll/regmap/phy/snd: Fix comment referencing outdated timer documentation
> powerpc/rtas: Use fsleep() to minimize additional sleep duration
> media: anysee: Fix link to outdated sleep function documentation
> timers/Documentation: Cleanup delay/sleep documentation

I like the changes, so

Acked-by: Rafael J. Wysocki <rafael@kernel.org>

for the series.