Re: [PATCH 10/15] checkpatch: Remove broken sleep/delay related checks

Joe Perches
2024-09-05T02:04:30Z

On Wed, 2024-09-04 at 15:05 +0200, Anna-Maria Behnsen wrote:
> checkpatch.pl checks for several things related to sleep and delay
> functions. In all warnings the outdated documentation is referenced. All
> broken parts are listed one by one in the following with an explanation why
> this check is broken. For a basic background of those functions please also
> refere to the updated function descriptions of udelay(), nsleep_range() and
> msleep().
[]
> - Check: ($1 < 20)
> Message: "msleep < 20ms can sleep for up to 20ms;
> see Documentation/timers/timers-howto.rst\n"
> Why is the check broken: The message is simply wrong. msleep() will not
> sleep (and never did it before)

While it might have changed, the "never did it before" is
not correct.

https://lore.kernel.org/all/15327.1186166232@lwn.net/

> Remove all broken checks. Remove also no longer required checkpatch
> documentation section about USLEEP_RANGE.

It'd be useful to remove the appropriate now unnecessary
verbose sections from Documentation/dev-tools/checkpatch.rst