Re: [PATCH 04/15] timers: Move *sleep*() and timeout functions into a separate file

Anna-Maria Behnsen
2024-09-09T08:10:18Z

Frederic Weisbecker <frederic@kernel.org> writes:

> Le Wed, Sep 04, 2024 at 03:04:54PM +0200, Anna-Maria Behnsen a écrit :
>> All schedule_timeout() and *sleep*() related functions are interfaces on
>> top of timer list timers and hrtimers to add a sleep to the code. As they
>> are built on top of the timer list timers and hrtimers, the [hr]timer
>> interfaces are already used except when queuing the timer in
>> schedule_timeout(). But there exists the appropriate interface add_timer()
>> which does the same job with an extra check for an already pending timer.
>>
>> Split all those functions as they are into a separate file and use
>> add_timer() instead of __mod_timer() in schedule_timeout().
>>
>> While at it fix minor formatting issues and a multi line printk function
>> call in schedule_timeout(). While at it also add not listed
>> include/linux/delay.h to the MAINTAINTERS file.
>
> I don't mind sometimes having several logical changes within a same
> patch if that makes sense but the delay is MAINTAINERS is pretty off-topic
> and should move to its own patch.

Ack. But, I was too slow to provide a v2. It's already applied in
tip. Should we change tip, or is ok for you?

Thanks,

Anna-Maria