From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8605165EFA for ; Tue, 6 Aug 2024 12:01:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722945691; cv=none; b=H/L6DIZlAo177N9KqLo860Ll3nXXTBnnSVfNSp+GIIIcIHI31H/T7YWQFpqCqOnpR2VvYNPC4ymQc1CESlDMzohowwisNcSdaJk5JSJg5ypaAl5UGuf+jtV8pA9oUPmmxPc5Wo8kMqo5nqW3sgdUS7NURiy4ebmyoWD3Om0Q3Zk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722945691; c=relaxed/simple; bh=Lugsx6fzDwyeoUcfvVDJLgsJHlh3ibZ4yuE5vwJULrI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=EMPJowESCVQwFo/nYuYqVKhy7eFiTaHmT6UIowE17ZX/6w9wa/BCt9pdTw6R23Ev8fHL1mEOB3kbX26uhgoJz4xw+45b8zuWfPAe4x/H94n/V6tsPgEVQ5hPdn1Kb7PgFC94Uc3gX+L0TpS/XxA2KrvhGaONbGvf6MTOwMpwkuY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cloudflare.com; spf=pass smtp.mailfrom=cloudflare.com; dkim=pass (2048-bit key) header.d=cloudflare.com header.i=@cloudflare.com header.b=CtTWSoPN; arc=none smtp.client-ip=209.85.218.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cloudflare.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cloudflare.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cloudflare.com header.i=@cloudflare.com header.b="CtTWSoPN" Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-a7a9cf7d3f3so71774666b.1 for ; Tue, 06 Aug 2024 05:01:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google09082023; t=1722945688; x=1723550488; darn=vger.kernel.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=SC/B0o7+RdgTPnb7EbqFy0h9TTXJHbv05EgMHed2hQM=; b=CtTWSoPNMagkvVC+duRMDzRo3hkUXDVqG54/wYPFyQAHcG+XyyseU9ZJIQscFWaeTy lq79QpXkVvF3Aw34hrlsJIKdhtkg2sG3gHskJpPFFe5u6UTzMqzKhHU0lqDUKh4GcDk8 K3r0OT9krfaCpmyHC+my2c4Gq0O2MMjnUg5FvTh3bqBVqNSzAbRgUGbanfXyoPOwjfQ0 MoOLmu8cls45V38tlqAfmb9YvsWzS3+/+uTWcm/QMwf3nEyfTOVYPrHd2S3+rbs8sYBB S4Y98UP+e1LfUqv/H3YPj8m/+m2TkbB7HUfS7Pyi/FUU2awOfmNDalO+0CEgboNsg0SI 0nog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722945688; x=1723550488; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=SC/B0o7+RdgTPnb7EbqFy0h9TTXJHbv05EgMHed2hQM=; b=sFdmM3P8HxBju0yCBhG6Hm7Eq1Xf2gcUzi6gfx9puXr3VM/gJLXqMEHr4XTGfVD4LC 7tsTA6kI3B1X+CUlTPbx05Dm5OfCwM7Rn+oYu7bw9bZJr+r056CaEw/LCAHrafjayUdV hsmMz0B2biPjm93qp0GJ6clANCTEOclQvmF7IpGOUTSNEfycxeWDSYHM1xRxyHgIg+Ol yP7XCnJn5RNKUU20Ly6mJUN7mqz0e9vivqCfFUfgVYf/9/0Bn0nsmM0PDELaxpBEVqHR Az0Dq0YXeOvTbGO1pg8zib1MW4bmhxOmRNEr+IfYoqTB/Zduxe8ZupUhlhYd2FmNgBLd p37w== X-Forwarded-Encrypted: i=1; AJvYcCVMAjCnIghHZLPoq4C5q4E297VNgwkEJyhOdUWeoxZ658wwyd2AYJXmfvWWEMdi41o4Af8u5z6LtKV7mReSx+JupgVwGF6wSKDoSp97 X-Gm-Message-State: AOJu0YyifVi1a1lVLrD4Slm3UePE8GkvaLSctuBBIDkSOGE4ZXfNnB9J vOmf48i1jDqPpL334PNVoYlq8Ijgm54skA71JQN84rvmhvyE+4Bph4RssCtWc24= X-Google-Smtp-Source: AGHT+IFZECUBQXofC+L4rA9OhKjiBlUfVSyXAns5FoFrow7eTVkumUQVC1WUleF3rWg3eVS8qyr7bQ== X-Received: by 2002:a17:906:db03:b0:a7a:b070:92cc with SMTP id a640c23a62f3a-a7dc5106e2amr1253822266b.45.1722945687914; Tue, 06 Aug 2024 05:01:27 -0700 (PDT) Received: from cloudflare.com ([2a09:bac5:5063:2387::38a:2f]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a7dc9c0c801sm539912666b.59.2024.08.06.05.01.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Aug 2024 05:01:26 -0700 (PDT) From: Jakub Sitnicki To: Michal Luczaj Cc: Andrii Nakryiko , Eduard Zingerman , Mykola Lysenko , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Shuah Khan , bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH bpf-next v2 0/6] selftests/bpf: Various sockmap-related fixes In-Reply-To: <20240731-selftest-sockmap-fixes-v2-0-08a0c73abed2@rbox.co> (Michal Luczaj's message of "Wed, 31 Jul 2024 12:01:25 +0200") References: <20240731-selftest-sockmap-fixes-v2-0-08a0c73abed2@rbox.co> User-Agent: mu4e 1.12.4; emacs 29.1 Date: Tue, 06 Aug 2024 14:01:25 +0200 Message-ID: <87y159yi5m.fsf@cloudflare.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Wed, Jul 31, 2024 at 12:01 PM +02, Michal Luczaj wrote: > Series takes care of few bugs and missing features with the aim to improve > the test coverage of sockmap/sockhash. > > Last patch is a create_pair() rewrite making use of > __attribute__((cleanup)) to handle socket fd lifetime. > > Signed-off-by: Michal Luczaj > --- > Changes in v2: > - Rebase on bpf-next (Jakub) > - Use cleanup helpers from kernel's cleanup.h (Jakub) > - Fix subject of patch 3, rephrase patch 4, use correct prefix > - Link to v1: https://lore.kernel.org/r/20240724-sockmap-selftest-fixes-v1-0-46165d224712@rbox.co > > Changes in v1: > - No declarations in function body (Jakub) > - Don't touch output arguments until function succeeds (Jakub) > - Link to v0: https://lore.kernel.org/netdev/027fdb41-ee11-4be0-a493-22f28a1abd7c@rbox.co/ > > --- > Michal Luczaj (6): > selftests/bpf: Support more socket types in create_pair() > selftests/bpf: Socket pair creation, cleanups > selftests/bpf: Simplify inet_socketpair() and vsock_socketpair_connectible() > selftests/bpf: Honour the sotype of af_unix redir tests > selftests/bpf: Exercise SOCK_STREAM unix_inet_redir_to_connected() > selftests/bpf: Introduce __attribute__((cleanup)) in create_pair() > > .../selftests/bpf/prog_tests/sockmap_basic.c | 28 ++-- > .../selftests/bpf/prog_tests/sockmap_helpers.h | 149 ++++++++++++++------- > .../selftests/bpf/prog_tests/sockmap_listen.c | 117 ++-------------- > 3 files changed, 124 insertions(+), 170 deletions(-) > --- > base-commit: 92cc2456e9775dc4333fb4aa430763ae4ac2f2d9 > change-id: 20240729-selftest-sockmap-fixes-bcca996e143b > > Best regards, Thanks again for these fixes. For the series: Reviewed-by: Jakub Sitnicki Tested-by: Jakub Sitnicki