From: Thomas Gleixner <tglx@linutronix.de>
To: Koakuma <koachan@protonmail.com>
Cc: Koakuma via B4 Relay <devnull+koachan.protonmail.com@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Andreas Larsson <andreas@gaisler.com>,
Andy Lutomirski <luto@kernel.org>,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev
Subject: Re: [PATCH] sparc/vdso: Add helper function for 64-bit right shift on 32-bit target
Date: Sun, 04 Aug 2024 21:16:45 +0200 [thread overview]
Message-ID: <87y15c5c9u.ffs@tglx> (raw)
In-Reply-To: <Y5IejvnMTMbzucl5EK4C9ptWTnkPJlPJVKyCj1L1o2_2GPbmY5GZ55bKckWzKATaZcFF9SLCcvI4EMOhG3sifxCgEtkSdV2KDhv5jRBy9wk=@protonmail.com>
On Sun, Aug 04 2024 at 17:30, Koakuma wrote:
> Thomas Gleixner <tglx@linutronix.de> wrote:
>> Why does this sparc'ism need to be in generic code?
>
> Doesn't x86 also have a couple functions that live in math64.h anyway?
No. Both functions are used in the generic lib/vdso/ code.
> That's why I thought it is fine to put it in there...
>
> In any case, though, I am open to moving the function to sparc directory,
> if that is indeed the proper place for that function.
I think so as sparc is having it's own VDSO implementation and does not
use the generic one.
Thanks,
tglx
next prev parent reply other threads:[~2024-08-04 19:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-04 3:39 [PATCH] sparc/vdso: Add helper function for 64-bit right shift on 32-bit target Koakuma via B4 Relay
2024-08-04 15:44 ` Thomas Gleixner
2024-08-04 17:30 ` Koakuma
2024-08-04 19:16 ` Thomas Gleixner [this message]
2024-08-06 2:02 ` Koakuma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y15c5c9u.ffs@tglx \
--to=tglx@linutronix.de \
--cc=andreas@gaisler.com \
--cc=davem@davemloft.net \
--cc=devnull+koachan.protonmail.com@kernel.org \
--cc=justinstitt@google.com \
--cc=koachan@protonmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=luto@kernel.org \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=sparclinux@vger.kernel.org \
--cc=vincenzo.frascino@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox