From: "Toke Høiland-Jørgensen" <toke@kernel.org>
To: Rosen Penev <rosenp@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ath9k: use devm for gpio_request_one
Date: Fri, 02 Aug 2024 12:00:43 +0200 [thread overview]
Message-ID: <87y15f6y7o.fsf@toke.dk> (raw)
In-Reply-To: <CAKxU2N_b51S=gDthQtM+aRnCt1Zg1SrodjmLF3u9aV+Y6GefAg@mail.gmail.com>
Rosen Penev <rosenp@gmail.com> writes:
> On Thu, Aug 1, 2024 at 1:26 AM Toke Høiland-Jørgensen <toke@kernel.org> wrote:
>>
>> Rosen Penev <rosenp@gmail.com> writes:
>>
>> > No need to manually free the gpio now.
>> >
>> > Remove if statement as it's redundant now. The gpio bit now gets cleared
>> > whether set or not.
>> >
>> > Signed-off-by: Rosen Penev <rosenp@gmail.com>
>>
>> So presumably these will conflict with this patch?
>>
>> https://patchwork.kernel.org/project/linux-wireless/patch/3b46f6c7-4372-4cc9-9a7c-2c1c06d29324@gmail.com/
> This does not look related.
Ah, no, you're right; was confusing the PCI-internal device managed
thing with the generic one :)
-Toke
prev parent reply other threads:[~2024-08-02 10:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-31 21:00 [PATCH] net: ath9k: use devm for gpio_request_one Rosen Penev
2024-08-01 8:26 ` Toke Høiland-Jørgensen
2024-08-01 8:50 ` Rosen Penev
2024-08-02 10:00 ` Toke Høiland-Jørgensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y15f6y7o.fsf@toke.dk \
--to=toke@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rosenp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox