Re: [PATCH] powerpc: add missing MODULE_DESCRIPTION() macros

Jeff Johnson
2024-06-29T03:13:26Z

On 6/15/2024 10:06 AM, Jeff Johnson wrote:
> With ARCH=powerpc, make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in arch/powerpc/kernel/rtas_flash.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in arch/powerpc/sysdev/rtc_cmos_setup.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in arch/powerpc/platforms/pseries/papr_scm.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in arch/powerpc/platforms/cell/spufs/spufs.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in arch/powerpc/platforms/cell/cbe_thermal.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in arch/powerpc/platforms/cell/cpufreq_spudemand.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in arch/powerpc/platforms/cell/cbe_powerbutton.o
>
> Add the missing invocation of the MODULE_DESCRIPTION() macro to all
> files which have a MODULE_LICENSE().
>
> This includes 85xx/t1042rdb_diu.c and chrp/nvram.c which, although
> they did not produce a warning with the powerpc allmodconfig
> configuration, may cause this warning with other configurations.
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
> Corrections to these descriptions are welcomed. I'm not an expert in
> this code so in most cases I've taken these descriptions directly from
> code comments, Kconfig descriptions, or git logs. History has shown
> that in some cases these are originally wrong due to cut-n-paste
> errors, and in other cases the drivers have evolved such that the
> original information is no longer accurate.
> ---
> arch/powerpc/kernel/rtas_flash.c | 1 +
> arch/powerpc/platforms/85xx/t1042rdb_diu.c | 1 +
> arch/powerpc/platforms/cell/cbe_powerbutton.c | 1 +
> arch/powerpc/platforms/cell/cbe_thermal.c | 1 +
> arch/powerpc/platforms/cell/cpufreq_spudemand.c | 1 +
> arch/powerpc/platforms/cell/spufs/inode.c | 1 +
> arch/powerpc/platforms/chrp/nvram.c | 1 +
> arch/powerpc/platforms/pseries/papr_scm.c | 1 +
> arch/powerpc/sysdev/rtc_cmos_setup.c | 1 +
> 9 files changed, 9 insertions(+)
>
> diff --git a/arch/powerpc/kernel/rtas_flash.c b/arch/powerpc/kernel/rtas_flash.c
> index 359577ec1680..5407024881e5 100644
> --- a/arch/powerpc/kernel/rtas_flash.c
> +++ b/arch/powerpc/kernel/rtas_flash.c
> @@ -773,4 +773,5 @@ static void __exit rtas_flash_cleanup(void)
>
> module_init(rtas_flash_init);
> module_exit(rtas_flash_cleanup);
> +MODULE_DESCRIPTION("PPC procfs firmware flash interface");
> MODULE_LICENSE("GPL");
> diff --git a/arch/powerpc/platforms/85xx/t1042rdb_diu.c b/arch/powerpc/platforms/85xx/t1042rdb_diu.c
> index 767eed98a0a8..d4fbb6eff38a 100644
> --- a/arch/powerpc/platforms/85xx/t1042rdb_diu.c
> +++ b/arch/powerpc/platforms/85xx/t1042rdb_diu.c
> @@ -149,4 +149,5 @@ static int __init t1042rdb_diu_init(void)
>
> early_initcall(t1042rdb_diu_init);
>
> +MODULE_DESCRIPTION("Freescale T1042 DIU driver");
> MODULE_LICENSE("GPL");
> diff --git a/arch/powerpc/platforms/cell/cbe_powerbutton.c b/arch/powerpc/platforms/cell/cbe_powerbutton.c
> index a3ee397486f6..3d121acdf69b 100644
> --- a/arch/powerpc/platforms/cell/cbe_powerbutton.c
> +++ b/arch/powerpc/platforms/cell/cbe_powerbutton.c
> @@ -101,5 +101,6 @@ static void __exit cbe_powerbutton_exit(void)
> module_init(cbe_powerbutton_init);
> module_exit(cbe_powerbutton_exit);
>
> +MODULE_DESCRIPTION("Driver for powerbutton on IBM cell blades");
> MODULE_LICENSE("GPL");
> MODULE_AUTHOR("Christian Krafft <krafft@de.ibm.com>");
> diff --git a/arch/powerpc/platforms/cell/cbe_thermal.c b/arch/powerpc/platforms/cell/cbe_thermal.c
> index 2f45428e32c8..c295c6714f9b 100644
> --- a/arch/powerpc/platforms/cell/cbe_thermal.c
> +++ b/arch/powerpc/platforms/cell/cbe_thermal.c
> @@ -381,6 +381,7 @@ static void __exit thermal_exit(void)
> }
> module_exit(thermal_exit);
>
> +MODULE_DESCRIPTION("Cell processor thermal driver");
> MODULE_LICENSE("GPL");
> MODULE_AUTHOR("Christian Krafft <krafft@de.ibm.com>");
>
> diff --git a/arch/powerpc/platforms/cell/cpufreq_spudemand.c b/arch/powerpc/platforms/cell/cpufreq_spudemand.c
> index ca7849e113d7..79172ba36eca 100644
> --- a/arch/powerpc/platforms/cell/cpufreq_spudemand.c
> +++ b/arch/powerpc/platforms/cell/cpufreq_spudemand.c
> @@ -129,5 +129,6 @@ static struct cpufreq_governor spu_governor = {
> cpufreq_governor_init(spu_governor);
> cpufreq_governor_exit(spu_governor);
>
> +MODULE_DESCRIPTION("SPU-aware cpufreq governor for the cell processor");
> MODULE_LICENSE("GPL");
> MODULE_AUTHOR("Christian Krafft <krafft@de.ibm.com>");
> diff --git a/arch/powerpc/platforms/cell/spufs/inode.c b/arch/powerpc/platforms/cell/spufs/inode.c
> index 030de2b8c145..70236d1df3d3 100644
> --- a/arch/powerpc/platforms/cell/spufs/inode.c
> +++ b/arch/powerpc/platforms/cell/spufs/inode.c
> @@ -822,6 +822,7 @@ static void __exit spufs_exit(void)
> }
> module_exit(spufs_exit);
>
> +MODULE_DESCRIPTION("SPU file system");
> MODULE_LICENSE("GPL");
> MODULE_AUTHOR("Arnd Bergmann <arndb@de.ibm.com>");
>
> diff --git a/arch/powerpc/platforms/chrp/nvram.c b/arch/powerpc/platforms/chrp/nvram.c
> index 0eedae96498c..d3bf56a46656 100644
> --- a/arch/powerpc/platforms/chrp/nvram.c
> +++ b/arch/powerpc/platforms/chrp/nvram.c
> @@ -92,4 +92,5 @@ void __init chrp_nvram_init(void)
> return;
> }
>
> +MODULE_DESCRIPTION("PPC NVRAM device driver");
> MODULE_LICENSE("GPL v2");
> diff --git a/arch/powerpc/platforms/pseries/papr_scm.c b/arch/powerpc/platforms/pseries/papr_scm.c
> index 9b6420eb3567..f6a70bc92e83 100644
> --- a/arch/powerpc/platforms/pseries/papr_scm.c
> +++ b/arch/powerpc/platforms/pseries/papr_scm.c
> @@ -1536,5 +1536,6 @@ static void __exit papr_scm_exit(void)
> module_exit(papr_scm_exit);
>
> MODULE_DEVICE_TABLE(of, papr_scm_match);
> +MODULE_DESCRIPTION("PAPR Storage Class Memory interface driver");
> MODULE_LICENSE("GPL");
> MODULE_AUTHOR("IBM Corporation");
> diff --git a/arch/powerpc/sysdev/rtc_cmos_setup.c b/arch/powerpc/sysdev/rtc_cmos_setup.c
> index 47cc87bd6a33..9a232ae5e360 100644
> --- a/arch/powerpc/sysdev/rtc_cmos_setup.c
> +++ b/arch/powerpc/sysdev/rtc_cmos_setup.c
> @@ -66,4 +66,5 @@ static int __init add_rtc(void)
> }
> fs_initcall(add_rtc);
>
> +MODULE_DESCRIPTION("PPC RTC CMOS driver");
> MODULE_LICENSE("GPL");
>
> ---
> base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670
> change-id: 20240615-md-powerpc-arch-powerpc-c8b981be95f8

Following up to see if anything else is needed from me. Hoping to see this in
linux-next so I can remove it from my tracking spreadsheet :)

/jeff