From: Thomas Gleixner <tglx@linutronix.de>
To: Huacai Chen <chenhuacai@loongson.cn>
Cc: loongarch@lists.linux.dev, linux-kernel@vger.kernel.org,
Xuefeng Li <lixuefeng@loongson.cn>,
Huacai Chen <chenhuacai@gmail.com>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
Huacai Chen <chenhuacai@loongson.cn>,
stable@vger.kernel.org, Tianli Xiong <xiongtianli@loongson.cn>
Subject: Re: [PATCH] irqchip/loongson-liointc: Set different ISRs for different cores
Date: Fri, 21 Jun 2024 20:40:17 +0200 [thread overview]
Message-ID: <87y16ym966.ffs@tglx> (raw)
In-Reply-To: <20240612070106.2060334-1-chenhuacai@loongson.cn>
On Wed, Jun 12 2024 at 15:01, Huacai Chen wrote:
> In the liointc hardware, there are different ISRs for different cores.
I have no idea what ISR means in that context. Can you please spell it
out with proper words so that people not familiar with the details can
understand it?
> We always use core#0's ISR before but has no problem, it is because the
> interrupts are routed to core#0 by default. If we change the routing,
> we should set correct ISRs for different cores.
We do nothing. The code does.
See https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#changelog
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Tianli Xiong <xiongtianli@loongson.cn>
> Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
This Signed-off-by chain is wrong. If Tianli is the author then this
needs a From: Tianli in the changelog. If you developed it together then
this lacks a Co-developed-by tag.
See Documentation/process/
Thanks,
tglx
next prev parent reply other threads:[~2024-06-21 18:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-12 7:01 [PATCH] irqchip/loongson-liointc: Set different ISRs for different cores Huacai Chen
2024-06-21 18:40 ` Thomas Gleixner [this message]
2024-06-22 2:25 ` Huacai Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y16ym966.ffs@tglx \
--to=tglx@linutronix.de \
--cc=chenhuacai@gmail.com \
--cc=chenhuacai@loongson.cn \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lixuefeng@loongson.cn \
--cc=loongarch@lists.linux.dev \
--cc=stable@vger.kernel.org \
--cc=xiongtianli@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox