Re: [PATCH v4 05/11] mm: do not split a folio if it has minimum folio order requirement

Matthew Wilcox
2024-05-01T04:14:09Z

On Tue, Apr 30, 2024 at 12:27:04PM -0700, Luis Chamberlain wrote:
> 2a:* 8b 43 34 mov 0x34(%rbx),%eax <-- trapping instruction
> RBX: 0000000000000002 RCX: 0000000000018000

Thanks, got it. I'll send a patch in the morning, but I know exactly
what the problem is. You're seeing sibling entries tagged as dirty.
That shouldn't happen; we should only see folios tagged as dirty.
The bug is in node_set_marks() which calls node_mark_all(). This works
fine when splitting to order 0, but we should only mark the first entry
of each order. eg if we split to order 3, we should tag slots 0, 8,
16, 24, .., 56.