Re: [PATCH v4 06/11] filemap: cap PTE range to be created to i_size in folio_map_range()

Matthew Wilcox
2024-04-25T20:24:39Z

On Thu, Apr 25, 2024 at 01:37:41PM +0200, Pankaj Raghav (Samsung) wrote:
> do {
> unsigned long end;
> + unsigned long i_size;

Usually i_size is the name of a variable that contains an loff_t, not a
page count. Not sure what to call this though. Also, can't we move
this outside the loop?

pgoff_t file_end = DIV_ROUND_UP(i_size_read(mapping->host),
PAGE_SIZE) - 1;

if (end_pgoff > file_end)
end_pgoff = file_end;